Skip to content

sched/wait: wait_event*_timeout() needs ___wait_cond_timeout() too

Oleg Nesterov lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1sched/wait: wait_event*_timeout() needs ___wait_cond_timeout() tooinclude/linux/wait.h+3 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] sched/wait: wait_event*_timeout() needs ___wait_cond_timeout() too

And another patch we already discussed.

wait_event_timeout(wq, true, 0) still returns 0, this doesn't look right, and this doesn't match __wait_event_timeout(timeout => 0).

Sure, most probably nobody uses the constant timeout == 0, but this can break the code which does something like

	if (nonblock)
		timeout = 0;
	else
		timeout = TIMEOUT;

	success = wait_event_timeout(wq, CONDITION, timeout);

Oleg.