Skip to content

RFC xfrm: Remove ancient sleeping code

Steffen Klassert netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2xfrm: Remove ancient sleeping when the SA is in acquire stateinclude/net/netns/xfrm.h net/key/af_key.c net/xfrm/xfrm_policy.c +1 more+5 -440 replies
2/2net: Remove FLOWI_FLAG_CAN_SLEEPinclude/net/flow.h include/net/ipv6.h include/net/route.h +19 more+31 -460 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchEric Dumazet
SeriesA-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH RFC 0/2] xfrm: Remove ancient sleeping code

Does anyone still rely on the ancient sleeping when the SA is in acquire state? It is disabled by default since more that five years, but can cause indefinite task hangs if enabled and the needed state does not get resolved.

We now queue packets to the policy if the states are not yet resolved if we are in a code path that can not sleep. We could do this even in the case we can sleep. As a bonus, we can remove the FLOWI_FLAG_CAN_SLEEP flag because the only thing this flag does, is to notify xfrm that we are in a codepath that can sleep.

The two RFC patches to remove the sleeping code are in reply to this mail. I'd add this to the ipsec-next tree if there are no objections.