Skip to content

uprobes: fix fork() with the pending ret-probe(s)

Oleg Nesterov lkml 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 0 repliesNew
  2. v15 patches 16 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6uprobes: Change the callsite of uprobe_copy_process()kernel/events/uprobes.c kernel/fork.c+9 -90 replies
2/6uprobes: Introduce __create_xol_area()kernel/events/uprobes.c+25 -220 replies
3/6uprobes: Teach __create_xol_area() to accept the predefined vaddrkernel/events/uprobes.c+12 -80 replies
4/6uprobes: Change uprobe_copy_process() to dup return_instanceskernel/events/uprobes.c+43 -00 replies
5/6uprobes: Change uprobe_copy_process() to dup xol_areakernel/events/uprobes.c+28 -00 replies
6/6uprobes: Teach uprobe_copy_process() to handle CLONE_VFORKinclude/linux/uprobes.h kernel/events/uprobes.c kernel/fork.c+11 -50 replies

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchSrikar Dronamraju
1/6A-b
2/6A-b
3/6A-b
4/6A-b
5/6A-b
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] uprobes: fix fork() with the pending ret-probe(s)

Hello.

This series fixes the serious bug reported by Martin and David and cc's stable. See the changelog in 5/6.

The changes are minimal, I am sending v2 just in case before I ask to pull.

v2:

2/6: whitespace fix

4/6: update the changelog to explain why we do not cleanup
the child's stack instead

5/6: check area != NULL before dup xol_area

1-5: add the acks from Srikar. I assume he agrees with 6/6
as well.

Oleg.

 include/linux/uprobes.h |    4 +-
 kernel/events/uprobes.c |  156 ++++++++++++++++++++++++++++++++++++-----------
 kernel/fork.c           |    2 +-
 3 files changed, 123 insertions(+), 39 deletions(-)