Skip to content

percpu: Replace __get_cpu_var uses in core code V1

Christoph Lameter linux-arch lkml 1 version Applied

Status from this message: Thanks, applied to for-3.13/core

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 2 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/10net: Replace __get_cpu_var usesinclude/net/netfilter/nf_conntrack.h net/core/dev.c net/core/drop_monitor.c +5 more+15 -150 replies
2/10time: Replace __get_cpu_var useskernel/hrtimer.c kernel/irq_work.c kernel/sched/clock.c +5 more+35 -350 replies
3/10scheduler: Replace __get_cpu_var usesinclude/linux/kernel_stat.h kernel/events/callchain.c kernel/events/core.c +4 more+21 -210 replies
4/10mm: Replace __get_cpu_var useslib/radix-tree.c mm/memcontrol.c mm/memory-failure.c +3 more+9 -90 replies
5/10tracing: Replace __get_cpu_var usesinclude/linux/kprobes.h kernel/trace/ftrace.c kernel/trace/trace.c+4 -40 replies
6/10block: Replace __get_cpu_var usesblock/blk-iopoll.c block/blk-softirq.c fs/fscache/object.c+8 -81 reply
7/10rcu: Replace __get_cpu_var useskernel/rcutree.c kernel/rcutree_plugin.h+18 -181 reply
8/10percpu: Replace __get_cpu_var usesinclude/linux/percpu.h+1 -10 replies
9/10watchdog: Replace __get_cpu_var useskernel/watchdog.c+5 -50 replies
10/10kernel misc: Replace __get_cpu_var useskernel/printk/printk.c kernel/smp.c+7 -70 replies

Reviews trailers per patch

1 of 10 patches has a Reviewed-by or Acked-by.

PatchMasami Hiramatsu
1/10
2/10
3/10
4/10
5/10A-b
6/10
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/10] percpu: Replace __get_cpu_var uses in core code V1

__get_cpu_var() is used for multiple purposes in the kernel source. One of them is address calculation via the form &__get_cpu_var(x). This calculates the address for the instance of the percpu variable of the current processor based on an offset.

Other use cases are for storing and retrieving data from the current processors percpu area. __get_cpu_var() can be used as an lvalue when writing data or on the right side of an assignment.

__get_cpu_var() is defined as :

#define __get_cpu_var(var) (*this_cpu_ptr(&(var)))

__get_cpu_var() always only does an address determination. However, store and retrieve operations could use a segment prefix (or global register on other platforms) to avoid the address calculation.

this_cpu_write() and this_cpu_read() can directly take an offset into a percpu area and use optimized assembly code to read and write per cpu variables.

This patch converts __get_cpu_var into either an explicit address calculation using this_cpu_ptr() or into a use of this_cpu operations that use the offset. Thereby address calculations are avoided and less registers are used when code is generated.

At the end of the patchset all uses of __get_cpu_var have been removed so the macro is removed too.

The patchset includes passes over all arches as well. Once these operations are used throughout then specialized macros can be defined in non -x86 arches as well in order to optimize per cpu access by f.e. using a global register that may be set to the per cpu base.

Transformations done to __get_cpu_var()

1. Determine the address of the percpu instance of the current processor.

	DEFINE_PER_CPU(int, y);
	int *x = &__get_cpu_var(y);

    Converts to

	int *x = this_cpu_ptr(&y);

2. Same as #1 but this time an array structure is involved.

	DEFINE_PER_CPU(int, y[20]);
	int *x = __get_cpu_var(y);

    Converts to

	int *x = this_cpu_ptr(y);

3. Retrieve the content of the current processors instance of a per cpu variable.

	DEFINE_PER_CPU(int, u);
	int x = __get_cpu_var(y)

Converts to

	int x = __this_cpu_read(y);

4. Retrieve the content of a percpu struct

	DEFINE_PER_CPU(struct mystruct, y);
	struct mystruct x = __get_cpu_var(y);

Converts to

	memcpy(this_cpu_ptr(&x), y, sizeof(x));

5. Assignment to a per cpu variable

	DEFINE_PER_CPU(int, y)
	__get_cpu_var(y) = x;

Converts to

	this_cpu_write(y, x);

6. Increment/Decrement etc of a per cpu variable

	DEFINE_PER_CPU(int, y);
	__get_cpu_var(y)++

Converts to

	this_cpu_inc(y)

These conversions lead to some savings in code size.

Before

size arch/x86/boot/bzImage
text data bss dec hex filename
3996624 0 0 3996624 3cfbd0 arch/x86/boot/bzImage

After

size arch/x86/boot/bzImage
text data bss dec hex filename
3995840 0 0 3995840 3cf8c0 arch/x86/boot/bzImage