Skip to content

nocontrold: Eliminating ocfs2_controld v4

Goldwyn Rodrigues ocfs2-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 0 repliesNew

Changes since v3 from the cover letter

* Added version negotiation using DLM lock
* Used strlcpy() instead of memcpy()

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6Add clustername to cluster connectionfs/ocfs2/dlmglue.c fs/ocfs2/ocfs2.h fs/ocfs2/stackglue.c +2 more+23 -51 reply
1/6Add clustername to cluster connection+0 -00 replies
2/6Add DLM recovery callbacksfs/ocfs2/stack_user.c+38 -01 reply
2/6Add DLM recovery callbacks+0 -01 reply
2/6Add DLM recovery callbacks+0 -00 replies
3/6Shift allocation ocfs2_live_connection to user_connect()fs/ocfs2/stack_user.c+17 -181 reply
3/6Shift allocation ocfs2_live_connection to user_connect()+0 -01 reply
4/6Pass ocfs2_cluster_connection to ocfs2_this_nodefs/ocfs2/dlmglue.c fs/ocfs2/stack_o2cb.c fs/ocfs2/stack_user.c +2 more+25 -81 reply
5/6Framework for version LVBfs/ocfs2/stack_user.c+102 -01 reply
5/6Framework for version LVB+0 -01 reply
6/6Use the new DLM operation callbacks while requesting new lockspacefs/ocfs2/stack_user.c+73 -241 reply
6/6Use the new DLM operation callbacks while requesting new lockspace+0 -01 reply

Reviews trailers per patch

1 of 12 patches has a Reviewed-by or Acked-by.

PatchMark Fasheh
1/6
1/6
2/6
2/6
2/6
3/6
3/6
4/6R-b
5/6
5/6
6/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Ocfs2-devel] [PATCH 0/6] nocontrold: Eliminating ocfs2_controld v4

Hi,

This is an effort of removing ocfs2_controld.pcmk and getting ocfs2 DLM handling up to the times with respect to DLM (>=4.0.1) and corosync (2.3.x). AFAIK, cman also is being phased out for a unified corosync cluster stack.

fs/dlm performs all the functions with respect to fencing and node management and provides the API's to do so for ocfs2. For all future references, DLM stands for fs/dlm code.

The advantages are:
+ No need to run an additional userspace daemon (ocfs2_controld)
+ No contrrold devince handling and controld protocol
+ Shifting responsibilities of node management to DLM layer

For backward compatibility, we are keeping the controld handling code. Once enough time has passed we can remove a significant portion of the code.

This feature requires modification in the userspace ocfs2-tools. The changes can be found at:
https://github.com/goldwynr/ocfs2-tools branch: nocontrold Currently, not many checks are present in the userspace code, but that would change soon.

These changes were developed on linux-stable 3.11.y. However, the changes are applicable to the current upstream as well. If you wish to give the entire kernel a spin, the link is:

https://github.com/goldwynr/linux-stable branch: nocontrold

Changes since v3:
* Added version negotiation using DLM lock
* Used strlcpy() instead of memcpy()

Changes since v2:
* Joel's comments: patch re-factoring

Changes since v1:
* Backward compatibility with ocfs2_controld

Signature · 1 line
Goldwyn