Skip to content

RFC Allow CONFIG_DEBUG_SET_MODULE_RONX to be used on ARM

Russell King - ARM Linux linux-arm-kernel linux-arm-msm 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest0 of 3 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 3 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/3] Allow CONFIG_DEBUG_SET_MODULE_RONX to be used on ARM
Quoted 12 lines · Russell King - ARM Linux
Quoted 11 lines · Laura Abbott

Hi,

This is an RFC to allow CONFIG_DEBUG_SET_MODULE_RONX to be used on ARM. The current config description from x86 describes it best:

This option helps catch unintended modifications to loadable kernel module's text and read-only data. It also prevents execution of module data. Such protection may interfere with run-time code patching and dynamic kernel tracing - and they might also protect against certain classes of kernel exploits.

Quoted 5 lines
Quoted 3 lines

ARM was missing a few functions to modify the page tables so those have been added. I believe modules are always mapped with pages so changing them at map time should be acceptable. Comments/concerns are appreciated.

I've just tested this and it seems to work:

The only remaining question is whether DEBUG_SET_MODULE_RONX should be by default enabled. At the moment, the text says "if unsure, say N" but is that the right advice? Shouldn't we be encouraging people to have this option turned on unless there's a reason not to (eg, kprobes?)

How about adding:

	default y if !(FTRACE || KPROBES || JUMP_LABEL)

as KPROBES and JUMP_LABEL both use the text patching, and FTRACE uses probe_kernel_write(). We may need to add kgdb to that later too. Or maybe a dependency on the above?

One thing which comes to mind while looking at this: should arch/arm/kernel/patch.c be using the probe_kernel_* functions in mm/maccess.c? Also, should we look at improving this code so we can have RONX modules and still have working ftrace/kprobes etc?