Rework file::show_fdinfo method to use seq-files engine
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest6 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | procfs: Introduce sequential fdinfo enginefs/ include/ | +130 | 3 replies | |
| 2/6 | epoll: Use sequential fdinfo enginefs/ | +33 | 0 replies | |
| 3/6 | eventfd: Use sequential fdinfo enginefs/ | +27 | 0 replies | |
| 4/6 | signalfd: Use sequential fdinfo enginefs/ | +27 | 0 replies | |
| 5/6 | fsnotify: Use sequential fdinfo enginefs/ fs/ fs/ +1 more | +94 | 0 replies | |
| 6/6 | procfs: Drop legacy show_fdinfo file operationfs/ include/ | +0 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [patch 0/6] Rework file::show_fdinfo method to use seq-files engine
Hi, in criu we intensively use additional information provided by /proc/<pid>/fdinfo/<fd> particular to the object opened file represents. The output is printed out by file_operations::show_fdinfo method and the implementation of this method is pretty simple. Still I think better would be to convert this method to seq_operations pointer where all suppliers (epoll, eventfd and such) provide own seq-file operations. While this makes code a little more complex this will decrease the amount of kernel memory needed for output (because we won't need to provide all information in one pass but by chunks).
Please take a look, thanks!