Skip to content

Rework file::show_fdinfo method to use seq-files engine

Cyrill Gorcunov lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6procfs: Introduce sequential fdinfo enginefs/proc/fd.c include/linux/fs.h+130 -333 replies
2/6epoll: Use sequential fdinfo enginefs/eventpoll.c+33 -120 replies
3/6eventfd: Use sequential fdinfo enginefs/eventfd.c+27 -30 replies
4/6signalfd: Use sequential fdinfo enginefs/signalfd.c+27 -30 replies
5/6fsnotify: Use sequential fdinfo enginefs/notify/fanotify/fanotify_user.c fs/notify/fdinfo.c fs/notify/fdinfo.h +1 more+94 -470 replies
6/6procfs: Drop legacy show_fdinfo file operationfs/proc/fd.c include/linux/fs.h+0 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [patch 0/6] Rework file::show_fdinfo method to use seq-files engine

Hi, in criu we intensively use additional information provided by /proc/<pid>/fdinfo/<fd> particular to the object opened file represents. The output is printed out by file_operations::show_fdinfo method and the implementation of this method is pretty simple. Still I think better would be to convert this method to seq_operations pointer where all suppliers (epoll, eventfd and such) provide own seq-file operations. While this makes code a little more complex this will decrease the amount of kernel memory needed for output (because we won't need to provide all information in one pass but by chunks).

Please take a look, thanks!