Skip to content

nocontrold: Eliminating ocfs2_controld v4

Mark Fasheh ocfs2-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 of 6 patches 0 repliesNew

5 of 6 patches are in this archive. The cover letter announces 6.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
4/6Pass ocfs2_cluster_connection to ocfs2_this_node+0 -00 replies
5/6Framework for version LVB+0 -01 reply
5/6Framework for version LVB+0 -00 replies
6/6Use the new DLM operation callbacks while requesting new lockspace+0 -01 reply
6/6Use the new DLM operation callbacks while requesting new lockspace+0 -00 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchMark Fasheh
4/6R-b
5/6
5/6
6/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Ocfs2-devel] [PATCH 0/6] nocontrold: Eliminating ocfs2_controld v4
Quoted 32 lines · Joel Becker
Quoted 31 lines · Andrew Morton
Quoted 28 lines · On Fri, 18 Oct 2013 09:44:54 -0500 Goldwyn Rodrigues <[email protected]> wrote:

This is an effort of removing ocfs2_controld.pcmk and getting ocfs2 DLM handling up to the times with respect to DLM (>=4.0.1) and corosync (2.3.x). AFAIK, cman also is being phased out for a unified corosync cluster stack.

fs/dlm performs all the functions with respect to fencing and node management and provides the API's to do so for ocfs2. For all future references, DLM stands for fs/dlm code.

The advantages are:
+ No need to run an additional userspace daemon (ocfs2_controld)
+ No contrrold devince handling and controld protocol
+ Shifting responsibilities of node management to DLM layer

For backward compatibility, we are keeping the controld handling code. Once enough time has passed we can remove a significant portion of the code.

This feature requires modification in the userspace ocfs2-tools. The changes can be found at:
https://github.com/goldwynr/ocfs2-tools branch: nocontrold Currently, not many checks are present in the userspace code, but that would change soon.

These changes were developed on linux-stable 3.11.y. However, the changes are applicable to the current upstream as well. If you wish to give the entire kernel a spin, the link is:

https://github.com/goldwynr/linux-stable branch: nocontrold

Quoted 7 lines
Quoted 3 lines

I queued this up so it will get some linux-next exposure when Stephen gets back to his desk. But I don't feel I can take it further without suitable input from the other ocfs2 developers (please).

I thought I'd been pretty clear on the previous rounds. The code had some significant issues in its approach to compatibility (it wasn't). I haven't had a chance to look at this round yet, but I intend to soon.

FYI this round seems to include backwards compat code.

Quoted 2 lines

Please do not forward this code without an explicit Acked-by from Mark or I.

By forward I assume you mean to Linus? I agree this doesn't want to go upstream yet but since the backwards compat code is in now I think it's probably a good thing that this gets tested in linux-next.

	--Mark

--
Mark Fasheh