Skip to content

Add support for SPI based DataImage LCD panel

Anatolij Gustschin u-boot 1 version New

Get series with b4
b4 am 20131106111439.09251ddb@crub

Versions newest first

  1. v2 Latest6 patches 0 repliesNew

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6spi: omap3: remove semicolon from #define+0 -00 replies
2/6spi: omap3: add support for more word lengths+0 -00 replies
3/6spi: define SPI_XFER_ONCE+0 -00 replies
4/6lcd: add DataImage SCF0403x LCD panel support+0 -00 replies
4/6lcd: add DataImage SCF0403x LCD panel support+0 -00 replies
5/6omap3_dss: define DSS_ONOFF+0 -00 replies
5/6omap3_dss: define DSS_ONOFF+0 -00 replies
6/6cm_t35: use scf0403 driver+0 -00 replies

Reviews trailers per patch

4 of 8 patches have a Reviewed-by or Acked-by.

PatchAnatolij Gustschin
1/6
2/6
3/6
4/6A-b
4/6A-b
5/6A-b
5/6A-b
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [U-Boot] [PATCH V2 0/6] Add support for SPI based DataImage LCD panel
Quoted 64 lines · On Mon, 4 Nov 2013 15:49:57 -0500 Tom Rini <[email protected]> wrote:
Quoted 47 lines · Nikita Kiryanov

This patch ports the Linux driver for DataImage SCF0403852GGU04 and SCF0403526GGU20 LCD panels into U-Boot. As a preparation step, variable SPI word length support is added to omap3_spi and the generic SPI interface. Finally, the driver is used in cm_t35 board.

The SPI changes were tested with a Beagle I2C/SPI/MDIO Protocol Analyzer, and also with a DataImage SCF0403 lcd as part of the DataImage driver test.

Patch number 6 depends on http://patchwork.ozlabs.org/patch/275283/

Cc Tom Rini <[email protected]>
Cc Anatolij Gustschin <[email protected]>
Cc Igor Grinberg <[email protected]>
Cc Jagannadha Sutradharudu Teki <[email protected]>

Changes in V2:
- Rebased on top of latest U-Boot
- New patches:
1) spi: omap3: remove semicolon from #define
2) spi: define SPI_XFER_ONCE
3) omap3_dss: define DSS_ONOFF
1 is a preliminary cleanup suggested by Gerhard Sittig and Igor Grinberg 2 and 3 are splitting off some new #defines to separate patches
- Moved wordlen to generic spi_slave struct, and added generic implementation for spi_set_wordlen which only updates the struct without touching the hardware (Igor Grinberg)
- Updated wordlen in hardware just before doing SPI transactions, not when changing wordlen (Igor Grinberg)
- OMAP3 specific check of wordlen value from old implementation of spi_set_wordlen moved to xfer. It refines the more general check done in the new spi_set_wordlen.
- Fixed comment style in spi.h following a rebase on top of latest U-Boot
- Added SPDX-License-Identifier to all new files (Anatolij Gustschin)
- s/printf/puts for not formatted strings in scf0403 driver (Anatolij Gustschin)
- Do not fail scf0403 driver init if an invalid reset_gpio is given (Igor Grinberg)

Nikita Kiryanov (6):
spi: omap3: remove semicolon from #define
spi: omap3: add support for more word lengths
spi: define SPI_XFER_ONCE
lcd: add DataImage SCF0403x LCD panel support
omap3_dss: define DSS_ONOFF
cm_t35: use scf0403 driver

Quoted 14 lines
 arch/arm/include/asm/arch-omap3/dss.h |   9 +-
 board/compulab/cm_t35/cm_t35.c        |  12 ++
 board/compulab/common/omap3_display.c |  46 +++++-
 drivers/spi/omap3_spi.c               |  71 +++++---
 drivers/spi/omap3_spi.h               |   8 +-
 drivers/spi/spi.c                     |  13 ++
 drivers/video/Makefile                |   1 +
 drivers/video/scf0403_lcd.c           | 296 ++++++++++++++++++++++++++++++++++
 include/configs/cm_t35.h              |   3 +
 include/scf0403_lcd.h                 |  11 ++
 include/spi.h                         |  17 ++
 11 files changed, 456 insertions(+), 31 deletions(-)
 create mode 100644 drivers/video/scf0403_lcd.c
 create mode 100644 include/scf0403_lcd.h
Quoted 2 lines

Did the mailing list eat the CC? I expect these changes to come in via the spi tree, since Anatolij acked the other parts. Thanks!

The patch this series depends on is not in u-boot.git/master branch yet (but in u-boot-arm.git tree already). So, after the arm tree is merged to master this series can be applied. I can push it via the video tree if nobody objects.

Thanks,
Anatolij