Skip to content

ARM: mvebu: fix DT def. of PCIe units for mv78230 and mv78260

Thomas Petazzoni linux-arm-kernel 1 version New

Get series with b4
b4 am 20131106192233.3599d256@skate

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ARM: mvebu: second PCIe unit of Armada XP mv78230 is only x1 capable+0 -04 replies
1/2ARM: mvebu: second PCIe unit of Armada XP mv78230 is only x1 capable+0 -00 replies
1/2ARM: mvebu: second PCIe unit of Armada XP mv78230 is only x1 capable+0 -00 replies
2/2ARM: mvebu: fix second and third PCIe unit of Armada XP mv78260+0 -00 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchThomas Petazzoni
1/2A-b
1/2A-b
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] ARM: mvebu: fix DT def. of PCIe units for mv78230 and mv78260

Dear Arnaud Ebalard,

Quoted 33 lines · Arnaud Ebalard
Quoted 33 lines

As a side note, Thomas, I noticed one more thing, this time in mv78460 .dtsi when comparing it w/ mv78230 and mv78260 ones. The first address of "assigned-address" property varies in the former for each pcie node:

$ grep assigned-address armada-xp-mv78230.dtsi 
         assigned-addresses = <0x82000800 0 0x40000 0 0x2000>;
         assigned-addresses = <0x82000800 0 0x44000 0 0x2000>;
         assigned-addresses = <0x82000800 0 0x48000 0 0x2000>;
         assigned-addresses = <0x82000800 0 0x4c000 0 0x2000>;
         assigned-addresses = <0x82000800 0 0x80000 0 0x2000>;
$ grep assigned-address armada-xp-mv78260.dtsi 
         assigned-addresses = <0x82000800 0 0x40000 0 0x2000>;
         assigned-addresses = <0x82000800 0 0x44000 0 0x2000>;
         assigned-addresses = <0x82000800 0 0x48000 0 0x2000>;
         assigned-addresses = <0x82000800 0 0x4c000 0 0x2000>;
         assigned-addresses = <0x82000800 0 0x80000 0 0x2000>;
         assigned-addresses = <0x82000800 0 0x84000 0 0x2000>;
         assigned-addresses = <0x82000800 0 0x88000 0 0x2000>;
         assigned-addresses = <0x82000800 0 0x8c000 0 0x2000>;
         assigned-addresses = <0x82000800 0 0x42000 0 0x2000>;
$ grep assigned-address armada-xp-mv78460.dtsi 
         assigned-addresses = <0x82000800 0 0x40000 0 0x2000>;
         assigned-addresses = <0x82001000 0 0x44000 0 0x2000>;
         assigned-addresses = <0x82001800 0 0x48000 0 0x2000>;
         assigned-addresses = <0x82002000 0 0x4c000 0 0x2000>;
         assigned-addresses = <0x82002800 0 0x80000 0 0x2000>;
         assigned-addresses = <0x82003000 0 0x84000 0 0x2000>;
         assigned-addresses = <0x82003800 0 0x88000 0 0x2000>;
         assigned-addresses = <0x82004000 0 0x8c000 0 0x2000>;
         assigned-addresses = <0x82004800 0 0x42000 0 0x2000>;
         assigned-addresses = <0x82005000 0 0x82000 0 0x2000>;
Quoted 7 lines
Quoted 3 lines

I took at Documentation/devicetree/bindings/pci/mvebu-pci.txt but failed to find an answer. Can you explain where the difference comes from?

Sorry to bother you again with the one above (it was in the cover letter) but the difference looks quite odd for someone not familiar with the syntax and the semantic.

I do still have this question in mind, I wanted to reply to it today but just hadn't had the time to do it. I'm adding Jason Gunthorpe in Cc because he knows better than me the precise meaning of assigned-addresses. If it doesn't reply, I'll try to have a look tomorrow. This is the kind of stuff I can't answer without concentrating for a bit of time to re-understand again how it all fits together :-)

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com