Skip to content

fs: forbid to open anon-inode files via /proc

Oleg Nesterov linux-next lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1fs: forbid to open anon-inode files via /procfs/inode.c+8 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] fs: forbid to open anon-inode files via /proc
Quoted 17 lines · Oleg Nesterov
Quoted 15 lines · Oleg Nesterov
Quoted 10 lines · Stephen Rothwell

Hi Andrew,

Today's linux-next merge of the akpm-current tree got a conflict in fs/anon_inodes.c between commit 24b0303e9532 ("take anon inode allocation to libfs.c") from the vfs tree and commit 02f3ac4386d9 ("anon_inodefs:
forbid open via /proc") from the akpm-current tree.

I just dropped the akpm-current changes for today - they should probably be applied to fs/libfs.c.

Well, this probably means that

Quoted 8 lines
Quoted 3 lines

anon_inodefs-forbid-open-via-proc.patch

should be dropped. I'll rediff this patch against vfs.git

24b0303e9532 also removes anon_inode_fops. It seems that it was not really needed anyway, inode_init_always() does inode->i_fop = empty_fops...

So probably we can simply change empty_fops but I need to recheck.

Well. It looks "really obvious" that any user of inode_init_always() either needs to change ->i_fop or this file should not be opened via /proc...

So, Al, feel free to ignore, this is minor. Still I think this patch makes sense. Based on vfs.git#for-next.

Oleg.