Socfpga: clk: trivial fixes and cleanup
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 4 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 4 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/4] Socfpga: clk: trivial fixes and cleanup
Hi Dinh,
Quoted 24 lines · Dinh Nguyen
Quoted 22 lines · Dinh Nguyen
Hi Steffen,
Quoted 9 lines · Steffen Trumtrar
Hi!
This series includes two trivial fixes to the code (1,2), then goes on to split the single
clk.cfile up into clock-type specific files (3) and finally adds a divider to the peripheral clock path.The patches are rebased to the for-next branch of
Quoted 8 lines
git://git.rocketboards.org/linux-socfpga-next.gitRegards,
SteffenSteffen Trumtrar (4):
ARM: socfpga: clk: remove unused field
ARM: socfpga: clk: fix define typoThe first two patches are fine.
Quoted 8 lines
Quoted 7 lines
Quoted 2 lines
ARM: socfpga: clk: split clk code
ARM: socfpga: clk: addclk_dividerto periphThese two patches are causing the ethernet driver to not be able to grab the correct clock during probe.
Lets wait for 3.13-rc1 and I will push a new for-next that will be more up-to-date.
Hm, okay. It works fine on my SoCKit. But maybe I missed something in the split up.
Quoted 7 lines
Also the values do not look correct with your patch:
per_nand_mmc_clk1 1 52631578nand_clk 0 0 13157894 nand_x_clk 0 0 52631578 sdmmc_clk 1 1 52631578
Quoted 7 lines
Without your patch:
per_nand_mmc_clk1 1 50000000nand_clk 0 0 12500000 nand_x_clk 0 0 50000000 sdmmc_clk 1 1 50000000
Yes. I can confirm that on my board, too. I actually seem to have read over those three values and missed them.
Let's wait for 3.13-rc1, then.
I actually also wanted to change the l3_sp_clk, as it seems to be neglect the "1 or 2" divider from l3_mp_clk IIRC, but I couldn't come up with a good way without changing the binding or something. What do you thing about that? Is that wrong at the moment or do I miss something?
Thanks,
Steffen
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |