Skip to content

: (Was: kmod: avoid propagating PF_NO_SETAFFINITY into userspace child)

Oleg Nesterov lkml 1 version Applied

Status from this message: Applied to wq/for-3.13-fixes.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 14 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/1workqueue: swap set_cpus_allowed_ptr() and PF_NO_SETAFFINITYkernel/workqueue.c+4 -450 replies
1/1usermodehelper: kill ____call_usermodehelper()->set_cpus_allowed_ptr()kernel/kmod.c+2 -612 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchOleg NesterovTejun Heo
1/1A-b A-b A-b
1/1A-b A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/1]: (Was: kmod: avoid propagating PF_NO_SETAFFINITY into userspace child)
Quoted 3 lines · Oleg Nesterov

Yes, but kernel_thread() is called by the worker thread which has PF_NO_SETAFFINITY, this flag is copied to child->flags.

Hmm, and it seems that create_worker() needs a minor fix, please see the patch.

Quoted 2 lines

Looks like Zhang is right... But I'd suggest to change flush_old_exec() instead (see "current->flags &= ...").

Yes.

But... May be we should (also?) change copy_flags() to clear PF_NO_SETAFFINITY? Probably not, this can lead to the subtle behaviour changes. But I am wondering if there is any kthread() which relies on PF_NO_SETAFFINITY copied by kernel_thread().

Oleg.