Skip to content

ARM: sa1100: Rework IRQ handling

Russell King - ARM Linux linux-arm-kernel linux-gpio 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 of 9 patches 0 repliesNew

1 of 9 patches is in this archive. The cover letter announces 9.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
7/9ARM: sa1100: move gpio irq handling to GPIO driver+0 -03 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/9] ARM: sa1100: Rework IRQ handling
Quoted 6 lines · Linus Walleij
Quoted 4 lines · Dmitry Eremin-Solenikov
Quoted 1 line · Linus Walleij

And that happens before the GPIO driver gets registered -> crash.

Quoted 8 lines
Quoted 2 lines

That is not the issue. The real issue is h3xxx using those gpio's without previously calling gpio_request.

Really? But that wasn't done before this patch either.

It is basically OK to use the gpio_* functions before or without requesting the GPIOs, it won't look nice but it works.

Using gpio_* functions without first having the GPIO requested causes a complaint at boot time... so it's really undesirable to do this.

Also note that we _do_ have sa11x0 platforms which request their GPIOs in their arch_initcall callback, so the sa11x0 GPIO driver better be around at that point otherwise things *will* fail.

I suspect that means the SA11x0 GPIO driver must be initialised early.