Skip to content

ARM: sa1100: Rework IRQ handling

Russell King - ARM Linux linux-arm-kernel linux-gpio 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 9 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 9 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/9] ARM: sa1100: Rework IRQ handling
Quoted 6 lines · Dmitry Eremin-Solenikov
Quoted 3 lines · Russell King - ARM Linux

Also note that we _do_ have sa11x0 platforms which request their GPIOs in their arch_initcall callback, so the sa11x0 GPIO driver better be around at that point otherwise things *will* fail.

Quoted 7 lines

Which ones if you have them in your mind?

Quoted 1 line

I suspect that means the SA11x0 GPIO driver must be initialised early.

Anyway in these patches gpio-sa1100 driver is registered at postcore initcall, so gpios should
be available before arch_initcall functions.

No it won't - quite simply because the platforms get called before sa1100_init() is run - they have to be because the platforms get to customise the platform data passed to the SA11x0 devices, which has to happen before sa1100_init() registers the devices.

By adding the GPIO device to the sa11x0_devices list, you're registering it afterwards which means that the GPIO driver isn't up and running at this time. That means that various platforms (such as the h3xxx ones which call gpio_request on built-in GPIOs at this time) will fail.