Skip to content

ARM: sa1100: Rework IRQ handling

Russell King - ARM Linux linux-arm-kernel linux-gpio 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 of 9 patches 0 repliesNew

1 of 9 patches is in this archive. The cover letter announces 9.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
7/9ARM: sa1100: move gpio irq handling to GPIO driver+0 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/9] ARM: sa1100: Rework IRQ handling
Quoted 17 lines · Dmitry Eremin-Solenikov
Quoted 15 lines · Russell King - ARM Linux
Quoted 13 lines · Dmitry Eremin-Solenikov
Quoted 3 lines · Russell King - ARM Linux

Also note that we _do_ have sa11x0 platforms which request their GPIOs in their arch_initcall callback, so the sa11x0 GPIO driver better be around at that point otherwise things *will* fail.

Which ones if you have them in your mind?

Quoted 1 line

I suspect that means the SA11x0 GPIO driver must be initialised early.

Anyway in these patches gpio-sa1100 driver is registered at postcore initcall, so gpios should
be available before arch_initcall functions.

Quoted 8 lines
Quoted 4 lines

No it won't - quite simply because the platforms get called before sa1100_init() is run - they have to be because the platforms get to customise the platform data passed to the SA11x0 devices, which has to happen before sa1100_init() registers the devices.

They both belong to arch_initicall level, aren't they? So ordering is guarded only by having customize_machine(which calls init_machine) from arch/arm/kernel/ before sa1100_init from arch/arm/mach-sa1100/?

Here:

c05b5194 T __initcall3_start
c05b5194 t __initcall_gate_vma_init3
c05b5198 t __initcall_customize_machine3
c05b519c t __initcall_exceptions_init3
c05b51a0 t __initcall_sa1100_init3
c05b51a4 t __initcall_dma_bus_init3
c05b51a8 t __initcall_dma_channel_table_init3
c05b51ac t __initcall_sa1110_clk_init3

* There we can see customize_machine() is called before sa1100_init().

* customize_machine() calls the machine specific .init_machine function.

* Several platforms call gpio_request() from their .init_machine function for SA11x0 GPIOs.

* You're adding the SA11x0 GPIO device in sa1100_init().

Therefore, those platforms which call gpio_request() will fail.

What is soo difficult to understand about this?

Quoted 3 lines

For sa1100 there are only 2.5 platforms which use gpiolib - collie and h3xxx. (The half is for simpad, which registers gpio chip from platform code, but doesn't use it otherwise -- in platform code, of course).

Oh well, I guess it doesn't matter then, if we're only breaking 2.5 platforms.

No. It does matter. This needs fixing.