Skip to content

initial while_each_thread() fixes

Oleg Nesterov lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 13 repliesIn review
  2. v12 patches 12 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4introduce for_each_thread() to replace the buggy while_each_thread()include/linux/init_task.h include/linux/sched.h kernel/exit.c +1 more+22 -07 replies
2/4oom_kill: change oom_kill.c to use for_each_thread()mm/oom_kill.c+10 -102 replies
3/4oom_kill: has_intersects_mems_allowed() needs rcu_read_lock()mm/oom_kill.c+11 -82 replies
4/4oom_kill: add rcu_read_lock() into find_lock_task_mm()mm/oom_kill.c+8 -42 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchSergey DyaslySameer NandaMichal HockoDavid Rientjes
1/4Reviewed-and-Tested-by R-b A-b
2/4Reviewed-and-Tested-by R-b R-b A-b
3/4Reviewed-and-Tested-by R-b R-b A-b
4/4R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/4] initial while_each_thread() fixes

Hello.

Changes: split the change in mm/oom_kill.c + update the comment above has_intersects_mems_allowed().

Sergey, Sameer, the resulting code is the same after 1-3, I preserved your acks.

4/4 is new.

Andrew, just in case, 3/4 and 4/4 try to fix the unrelated bugs, this has nothing to do with while_each_thread/for_each_thread changes.

To remind, this is the first series which changes the callers of the buggy while_each_thread(), I'll send more.

Oleg.

 include/linux/init_task.h |    2 +
 include/linux/sched.h     |   12 ++++++++++
 kernel/exit.c             |    1 +
 kernel/fork.c             |    7 ++++++
 mm/oom_kill.c             |   51 +++++++++++++++++++++++++-------------------
 5 files changed, 51 insertions(+), 22 deletions(-)