Skip to content

RFC DT support for ST micro accelerometers and gyroscopes

Maxime Ripard linux-arm-kernel linux-devicetree linux-iio 1 version New

Get series with b4
b4 am 20131203212914.GC31496@lukather

Versions newest first

  1. v1 RFC Latest0 of 3 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 3 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/3] DT support for ST micro accelerometers and gyroscopes

Hi Jean,

Quoted 12 lines · Jean Delvare
Quoted 12 lines

i2c has a generic binding that matches to the name bit of the i2c_device_id array. That is then exported in sysfs. There are quite a lot of instances of underscores out there in these names. Thus unforutnately they can't be changed without possibly breaking userspace. Typically those same names are also output by IIO though obviously we could keep that the same whilst changing the dt binding.

Also the i2c binding allows binding after dropping the vendor prefix which is even more 'interesting'. See of_modialias_node in drivers/of/base.c

Quoted 7 lines
Quoted 3 lines

I'd therefore argue in favour of just leaving the underscores in existing drivers as a nasty bit of legacy and doing our best to not introduce any new ones!

I don't know what is the problem with underscores, but please note that hwmon i2c devices are NOT allowed to have dashes in their name because that would break libsensors.

As far as I remember, hwmon doesn't handle the accelerometers or gyroscopes, does it?

Thanks,
Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131203/f2dacea7/attachment.sig>