Skip to content

mtd: spi-nor: add a new framework for SPI NOR

Huang Shijie linux-arm-kernel linux-mtd linux-spi 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 4 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 4 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] mtd: spi-nor: add a new framework for SPI NOR
Quoted 19 lines · Brian Norris
Quoted 18 lines · Huang Shijie
Quoted 9 lines · Brian Norris

I mostly bring this up, though, because it is an example of hardware that

(a) can operate as a true SPI device (hardware (1) can handle generic SPI transfers), but
(b) requires knowledge of the details of SPI flash in order to get optimal usage out of the acceleration from (2).

Quoted 4 lines

In my book, point (a) and (b) hold some bearing over the question of "where should this SPI NOR framework live", because it is reasonable that a single driver for this hardware should be able to handle either true SPI devices or accelerated SPI-NOR flash.

We have add a @read_id hook for the spi-nor layer, you can use it to read out more info (such as the Device Geometry Definition) for your spi-nor controller driver.

Quoted 7 lines
Quoted 1 line

Is it okay?

I'm not sure which @read_id hook you're talking about, as I've only skimmed the most recent thread, and it's not in the last patch series I have from you, I don't think. But that is not a response at all to the points I brought up. My statements have nothing to do with device geometry detection.

My meaning is You can write a new driver for the (b) with the new spi-nor layer,

In the new driver you can implement the @read_id yourself, and read out the the necessary info, and implement other hooks for the so-called peculiarities.

Quoted 7 lines

What I was actually addressing:

Your framework aligns with Mark's original suggestion: that the "SPI NOR" framework should be a separate layer held entirely within the MTD subsystem, and that any given driver is *either* a "SPI NOR" driver *or* a "true SPI" driver, not both.

You can only use a SPI-NOR driver, and you can abandon the "true SPI" driver.

Is there some limits that prevent we just code a SPI-NOR driver for your hardware?

thanks
Huang Shijie