misc log recovery patches
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | xfs: fix double free on error when cleaning log itemsfs/ | +3 | 1 reply | |
| 2/2 | xfs: free the efi AIL entry on log recovery failurefs/ | +21 | 5 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] misc log recovery patches
A couple log recovery patches.
patch 1 is a correction to commit:
commit 2a84108fe275f95fbe838b1c92b7c45258dcae5c Author: Mark Tinguely <[email protected]> Date: Wed Oct 2 07:51:12 2013 -0500 xfs: free the list of recovery items on error
Errors in phase 1/2 of xlog_recover_commit_trans will free the transaction pointer and the new call to xlog_recover_process_data will reuse and refree the pointer. I missed it in testing of the 2a84108 patch. Found by Dan Carpenter and verified by forcing an error in xlog_recover_process_data.
---
patch 2 is the second version of the patch to remove the EFI from the AIL when log recovery of the EFI item fails. If the EFI entry is not removed from the AIL, then xfs_ail_push_all_sync will hang while doing the forced shutdown. I moved the removal of all EFIs from the AIL to the caller, xlog_recover_process_efis to catch all the errors coming from xlog_recover_process_efi. This bug was found and verified using a metadata dump of a filesystem that has an error freeing an extent.
Mark.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs