Skip to content

ARM: S3C24XX: convert s3c2410, s3c2440 s3c2442 to common clock framework

Heiko Stübner linux-arm-kernel linux-devicetree linux-samsung-soc 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12ARM: S3C24XX: cpufreq-utils: don't write raw values to MPLLCON when using ccfarch/arm/mach-s3c24xx/cpufreq-utils.c+13 -01 reply
2/12dt-bindings: document s3c24xx controller for external clock outputDocumentation/devicetree/bindings/clock/samsung,s3c2410-dclk.txt+53 -01 reply
2/12dt-bindings: document s3c24xx controller for external clock output+0 -01 reply
3/12clk: samsung: add clock driver for external clock outputsdrivers/clk/samsung/Makefile drivers/clk/samsung/clk-s3c2410-dclk.c include/dt-bindings/clock/samsung,s3c2410-dclk.h+546 -02 replies
4/12ARM: S3C24XX: enable usage of common dclk if common clock framework is enabledarch/arm/mach-s3c24xx/Kconfig arch/arm/mach-s3c24xx/common.c arch/arm/mach-s3c24xx/common.h +7 more+66 -50 replies
5/12ARM: S3C24XX: only store clock registers when old clock code is activearch/arm/mach-s3c24xx/pm.c+4 -30 replies
6/12clk: samsung: add plls used by the early s3c24xx cpusdrivers/clk/samsung/clk-pll.c drivers/clk/samsung/clk-pll.h+185 -01 reply
8/12clk: samsung: add clock controller driver for s3c2410, s3c2440 and s3c2442drivers/clk/samsung/Makefile drivers/clk/samsung/clk-s3c2410.c include/dt-bindings/clock/samsung,s3c2410-clock.h+493 -02 replies
8/12clk: samsung: add clock controller driver for s3c2410, s3c2440 and s3c2442+0 -01 reply
8/12clk: samsung: add clock controller driver for s3c2410, s3c2440 and s3c2442+0 -00 replies
9/12ARM: S3C24XX: add platform code for conversion to the common clock frameworkarch/arm/mach-s3c24xx/Kconfig arch/arm/mach-s3c24xx/common.c arch/arm/mach-s3c24xx/common.h +3 more+51 -10 replies
10/12ARM: S3C24XX: convert s3c2440 and s3c2442 to common clock frameworkarch/arm/mach-s3c24xx/Kconfig arch/arm/mach-s3c24xx/Makefile arch/arm/mach-s3c24xx/common.c +9 more+73 -360 replies
11/12ARM: S3C24XX: convert s3c2410 to common clock frameworkarch/arm/mach-s3c24xx/Kconfig arch/arm/mach-s3c24xx/common.c arch/arm/mach-s3c24xx/mach-amlm5900.c +9 more+67 -340 replies
12/12ARM: S3C24XX: remove legacy clock codearch/arm/mach-s3c24xx/Kconfig arch/arm/mach-s3c24xx/Makefile arch/arm/mach-s3c24xx/clock-dclk.c +10 more+0 -11230 replies

Reviews trailers per patch

5 of 14 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMike TurquetteTomasz Figa
SeriesR-b A-b
1/12
2/12
2/12
3/12A-b
4/12
5/12
6/12A-b
8/12A-b
8/12A-b
8/12A-b
9/12
10/12
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/12] ARM: S3C24XX: convert s3c2410, s3c2440 s3c2442 to common clock framework

This series converts the earliest s3c socs to use a clock driver based on the common clock framework instead of the old Samsung clock implementation.

The only obstacle I found was the configuration of the clkout outputs in the different machines. As I lack hardware test and knowledge on what is expected there, somebody with interest in these machines will have to step up to implement the clkout configuration
This can for example be done in the machine_init function after the platform-devices (and thus the dclk-device) are populated.

This leaves the s3c2412 soc to be converted, as it has yet another different clock tree.

Tested on an Openmoko Neo Freerunner (S3C2442), but of course more tests would be really helpful.

Heiko Stuebner (12):
ARM: S3C24XX: cpufreq-utils: don't write raw values to MPLLCON when using ccf
dt-bindings: document s3c24xx controller for external clock output
clk: samsung: add clock driver for external clock outputs
ARM: S3C24XX: enable usage of common dclk if common clock framework is enabled
ARM: S3C24XX: only store clock registers when old clock code is active
clk: samsung: add plls used by the early s3c24xx cpus
dt-bindings: add documentation for s3c2410 clock controller
clk: samsung: add clock controller driver for s3c2410, s3c2440 and s3c2442
ARM: S3C24XX: add platform code for conversion to the common clock framework
ARM: S3C24XX: convert s3c2440 and s3c2442 to common clock framework
ARM: S3C24XX: convert s3c2410 to common clock framework
ARM: S3C24XX: remove legacy clock code

 .../bindings/clock/samsung,s3c2410-clock.txt       |   50 ++
 .../bindings/clock/samsung,s3c2410-dclk.txt        |   53 ++
 arch/arm/mach-s3c24xx/Kconfig                      |   50 +-
 arch/arm/mach-s3c24xx/Makefile                     |    6 +-
 arch/arm/mach-s3c24xx/clock-dclk.c                 |  195 --------
 arch/arm/mach-s3c24xx/clock-s3c2410.c              |  285 -----------
 arch/arm/mach-s3c24xx/clock-s3c2440.c              |  217 --------
 arch/arm/mach-s3c24xx/clock-s3c244x.c              |  141 ------
 arch/arm/mach-s3c24xx/common.c                     |   45 +-
 arch/arm/mach-s3c24xx/common.h                     |   11 +-
 arch/arm/mach-s3c24xx/cpufreq-utils.c              |   13 +
 arch/arm/mach-s3c24xx/include/mach/regs-clock.h    |   18 -
 arch/arm/mach-s3c24xx/include/mach/regs-gpio.h     |    3 -
 arch/arm/mach-s3c24xx/mach-amlm5900.c              |    9 +-
 arch/arm/mach-s3c24xx/mach-anubis.c                |   15 +-
 arch/arm/mach-s3c24xx/mach-at2440evb.c             |   10 +-
 arch/arm/mach-s3c24xx/mach-bast.c                  |   15 +-
 arch/arm/mach-s3c24xx/mach-gta02.c                 |    8 +-
 arch/arm/mach-s3c24xx/mach-h1940.c                 |   10 +-
 arch/arm/mach-s3c24xx/mach-mini2440.c              |   10 +-
 arch/arm/mach-s3c24xx/mach-n30.c                   |   12 +-
 arch/arm/mach-s3c24xx/mach-nexcoder.c              |   10 +-
 arch/arm/mach-s3c24xx/mach-osiris.c                |   15 +-
 arch/arm/mach-s3c24xx/mach-otom.c                  |   10 +-
 arch/arm/mach-s3c24xx/mach-qt2410.c                |    9 +-
 arch/arm/mach-s3c24xx/mach-rx1950.c                |   15 +-
 arch/arm/mach-s3c24xx/mach-rx3715.c                |   10 +-
 arch/arm/mach-s3c24xx/mach-smdk2410.c              |    9 +-
 arch/arm/mach-s3c24xx/mach-smdk2440.c              |   10 +-
 arch/arm/mach-s3c24xx/mach-tct_hammer.c            |    9 +-
 arch/arm/mach-s3c24xx/mach-vr1000.c                |   15 +-
 arch/arm/mach-s3c24xx/pm.c                         |   13 +-
 arch/arm/mach-s3c24xx/s3c2410.c                    |   56 ---
 arch/arm/mach-s3c24xx/s3c2442.c                    |  111 -----
 arch/arm/mach-s3c24xx/s3c244x.c                    |   59 +--
 drivers/clk/samsung/Makefile                       |    2 +
 drivers/clk/samsung/clk-pll.c                      |  182 +++++++
 drivers/clk/samsung/clk-pll.h                      |    3 +
 drivers/clk/samsung/clk-s3c2410-dclk.c             |  517 ++++++++++++++++++++
 drivers/clk/samsung/clk-s3c2410.c                  |  428 ++++++++++++++++
 include/dt-bindings/clock/samsung,s3c2410-clock.h  |   64 +++
 include/dt-bindings/clock/samsung,s3c2410-dclk.h   |   28 ++
 42 files changed, 1575 insertions(+), 1176 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/clock/samsung,s3c2410-clock.txt
 create mode 100644 Documentation/devicetree/bindings/clock/samsung,s3c2410-dclk.txt
 delete mode 100644 arch/arm/mach-s3c24xx/clock-dclk.c
 delete mode 100644 arch/arm/mach-s3c24xx/clock-s3c2410.c
 delete mode 100644 arch/arm/mach-s3c24xx/clock-s3c2440.c
 delete mode 100644 arch/arm/mach-s3c24xx/clock-s3c244x.c
 create mode 100644 drivers/clk/samsung/clk-s3c2410-dclk.c
 create mode 100644 drivers/clk/samsung/clk-s3c2410.c
 create mode 100644 include/dt-bindings/clock/samsung,s3c2410-clock.h
 create mode 100644 include/dt-bindings/clock/samsung,s3c2410-dclk.h
Signature · 1 line
1.7.10.4