Skip to content

mm: thp: get_huge_page_tail() cleanups

Oleg Nesterov lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2mm: thp: __get_page_tail_foll() can use get_huge_page_tail()mm/internal.h+1 -40 replies
2/2mm: thp: turn compound_head() into BUG_ON(!PageTail) in get_huge_page_tail()include/linux/mm.h+3 -40 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAndrea Arcangeli
SeriesA-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] mm: thp: get_huge_page_tail() cleanups

On top of

mm-tail-page-refcounting-optimization-for-slab-and-hugetlbfs.patch

should not be applied without the ack from Andrea.

Quoted 3 lines · Andrea Arcangeli

The above diff looks a straightforward cleanup you could submit it as a separate patch in a v2 series.

OK, let me send this separately, because (afaics) put_compound_tail() needs more thinking.

See also 2/2. Again, I won't argue if you dislike this change even if it is correct, so please review and ack/nack. To me compound_head() in get_huge_page_tail() looks confusing, as if get_huge_page_tail() can accept a !PageTail page. But perhaps this is only because I am new to this code.

Oleg.