mtd: spi-nor: add a new framework for SPI NOR

+ Lee, Marek

Hi Huang,

Quoted 13 lines · Brian Norris

Quoted 4 lines · Huang Shijie

On Mon, Feb 24, 2014 at 06:37:34PM +0800, Huang Shijie wrote:
Could you please review this patch set? I really hope it can be merged as soon as possibel. But now, the patch set has stalled for a long time.

I'm sorry for the delay. Others are in the same position of delay (e.g., Lee's SPI-NOR driver), because I simply have not had the time to really devote this the attention it deserves, especially considering how it rearchitects such an important, commonly-used driver.

Nonetheless, I will try to give your patches some more attention soon.

Quoted 7 lines

Quoted 2 lines

Since you have pushed the patches for m25p80.c, i have to rebase this patch set again and again...

You mean locally? I promise you, I can handle rebasing on my reviewing end for small one-line conflicts like new chip IDs, so don't rebase and resend simply for that. Unless I find substantive things that you should change, I'd only expect at most one more rebase to be necessary.

Unfortunately, I did not get the time to review and test this sufficiently for the 3.15 merge window, but to avoid further delay, I've queued it up in l2-mtd.git [1] under its own branch for now. I rebased it myself, to accommodate for changes to m25p80.c since your submission. Please take a look at the branch.

If all goes well, I should merge the spinor branch into master some time after the 3.15 merge window closes, so it will get linux-next testing. For any additional comments/corrections (I have a few), please just submit patches on top, rather than resending the whole series.

Marek, what was your opinion on this series? Last response I saw was "looking good"; is that an Ack? Or did you have any more gating requests?

Personally, I think it looks ready enough, and it's better to merge this than not. I was able to test with my platforms, with no regression.