powerpc/512x: update COMMON_CLK support for MPC5125
Get series with b4
b4 am 20131218222023.23538.99276@quantumVersions newest first
- v1 Latest0 of 4 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 4 patches the cover letter announces are in this archive.
Reviews trailers per patch
| Patch | Mike Turquette |
|---|---|
| Series | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v1 0/4] powerpc/512x: update COMMON_CLK support for MPC5125
Quoting Gerhard Sittig (2013-12-10 05:11:33)
Quoted 5 lines
this series improves the previously introduced common clock support for MPC512x such that SoC variants 5123 and 5125 get addressed appropriately (MPC5125 turned out to be rather different from MPC5121 than I perceived before -- there is much more than "just two FECs and no MBX")
Quoted 8 lines
thus this series depends on "add
COMMON_CLKsupport for PowerPC MPC512x" (v6 sent in <[email protected]>, applicable on top of v3.13-rc1 or later, currently applied to mpc5xxx -next, available atgit://git.denx.de/linux-2.6-agust.gitnext)this series does not address the issue of outdated or missing device tree binding documentation for MPC512x peripherals -- that's the scope of a pending separate series
For the three clock patches:
Quoted 48 lines
v1 initial submission (2013-12-10)
- enforce an even divider value for SDHC (on all MPC512x variants)
- tell 5121/5123/5125 SoC variants apart and only register the appropriate set of clock items (i.e. refuse to access unused and reserved bits, and support those components which are only found on MPC5125)
- update the MPC5125 "tower" board DTS (although the code still works in the absence of device tree clock specs)the series passes 'checkpatch.pl --strict' except for two warnings which cannot get fixed because <
linux/clk-provider.h> dictates the data type and "fixing" the warning would break the buildWARNING: static const char * array should probably be static const char * const #256: FILE:
arch/powerpc/platforms/512x/clock-commonclk.c:500:
+static const char *parent_names_mux0_spdif[] = {WARNING: static const char * array should probably be static const char * const #260: FILE:
arch/powerpc/platforms/512x/clock-commonclk.c:504:
+static const char *parent_names_mux0_canin[] = {total: 0 errors, 2 warnings, 0 checks, 495 lines checked
the series was build-tested, and was run-tested on the MPC5121 ADS board
Matteo, can you verify the crystal frequency in the DTS update, please? And that v3.13-rc kernels with v6 of the
COMMON_CLKintroduction for MPC512x plus this series for MPC5125 operate your peripherals, both with an updated device tree as well as with a former device tree that lacks clock specs? Thank you! SettingCONFIG_COMMON_CLK_DEBUG=yin your .config and eyeballing/sys/kernel/debug/clk/clk_summarywill help you.Gerhard Sittig (4):
powerpc/512x: clk: minor comment updates powerpc/512x: clk: enforce even SDHC divider values powerpc/512x: clk: support MPC5121/5123/5125 SoC variants powerpc/512x: dts: add MPC5125 clock specsarch/powerpc/boot/dts/mpc5125twr.dts | 53 +++- arch/powerpc/include/asm/mpc5121.h | 7 +- arch/powerpc/platforms/512x/clock-commonclk.c | 369 +++++++++++++++++++++---- include/dt-bindings/clock/mpc512x-clock.h | 9 +- 4 files changed, 386 insertions(+), 52 deletions(-)Signature · 1 line
1.7.10.4