Skip to content

tracing: Fixes to event_triggers patches found by Fengguang's test bot

Steven Rostedt lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tracing: Add generic tracing_lseek() functioninclude/linux/ftrace.h kernel/trace/ftrace.c kernel/trace/trace.c +3 more+19 -280 replies
2/2tracing: Fix rcu handling of event_trigger_data filter fieldkernel/trace/trace.h kernel/trace/trace_events_trigger.c+6 -41 reply

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchPaul E. McKenney
1/2
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] tracing: Fixes to event_triggers patches found by Fengguang's test bot

Tom,

This is the changes I made to fix the reports that Fengguang's kbuild test bot found. I folded in your change that fixes the bug with -ENODEV used in kernel.h.

Paul,

I've Cc'd you because the second patch is fixing up RCU notation. The filter is protect by rcu_sched, and the first hunk of the patch is performed within a rcu_read_lock_sched(), and the second hunk is done on the write side. The tmp variable holds the old value, the value is updated, and then the new value gets updated. I emailed you so that you can verify that this all works.

Thanks!

-- Steve

git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
ftrace/core

Head SHA1: 05741e383228a79eeec83644181255d2171f9f7c

Steven Rostedt (Red Hat) (2):
tracing: Add generic tracing_lseek() function
tracing: Fix rcu handling of event_trigger_data filter field

----

 include/linux/ftrace.h              |  2 --
 kernel/trace/ftrace.c               | 25 ++++++-------------------
 kernel/trace/trace.c                | 14 +++++++++-----
 kernel/trace/trace.h                |  4 +++-
 kernel/trace/trace_events_trigger.c | 10 ++++++----
 kernel/trace/trace_stack.c          |  2 +-
 6 files changed, 25 insertions(+), 32 deletions(-)