rcu_dereference_check_fdtable fix/cleanups
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest2 patches 1 replyIn review
- v12 patches 5 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | introduce __fcheck_files() to fix rcu_dereference_check_fdtable(), kill rcu_my_thread_group_empty()fs/ include/ include/ +1 more | +23 | 0 replies | |
| 2/2 | change close_files() to use rcu_dereference_raw(files->fdt)fs/ | +9 | 0 replies |
Reviews trailers per patch
None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Paul E. McKenney |
|---|---|
| Series | A-b R-b R-b R-b |
| 1/2 | |
| 2/2 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/2] rcu_dereference_check_fdtable fix/cleanups
Quoted 8 lines · Paul E. McKenney
Quoted 3 lines · Oleg Nesterov
doesn't this look much simpler than adding the "bool unshared" argument and changing the callers?
I might be being too paranoid, but my concern with using
rcu_lock_acquire()andrcu_lock_release()
And I agree, I no longer suggest to use rcu_lock_acquire/release.
It seems that you misunderstood me, let me send v2 for review.
Oleg.
fs/file.c | 30 +++++++++++------------------- include/linux/fdtable.h | 35 +++++++++++++++++++++-------------- include/linux/rcupdate.h | 2 -- kernel/rcu/update.c | 11 ----------- 4 files changed, 32 insertions(+), 46 deletions(-)