ARM: shmobile: Conditionally select SMSC_PHY
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 8 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 8 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/8] ARM: shmobile: Conditionally select SMSC_PHY
Quoted 12 lines · Arnd Bergmann
Quoted 10 lines · Simon Horman
Quoted 6 lines · Simon Horman
Select the
SMSC_PHYif ethernet is enabled on shmbile boards that have an SMSC phy. This allows the SMSC-specific phy driver to be used rather than relying on generic phy code.Based on the renesas-devel-v3.13-rc7-20140107 tag
of my renesas tree.I have queued up these changes.
Quoted 8 lines
I don't have an objection to the patches themselves, but a general feeling that it would be better to have larger combined patches than splitting them out per board.
I'm cautious with this comment because most people seem to do the opposite and combine too many things into large patches, but I think when you have identical changeset comments and change the same
Kconfigfile in all of them, you can save yourself and the reviewers some work.
Thanks, I think that is a reasonable comment.
I expected to be more variance between the changes. And in particular I expected more than one PHY driver to be involved. But as I checked the hardware on each board, wrote a patch and tested it turned out that SMSC was used by all the boards. So I was left with a stack of very similar patches.
In hindsight it might have been better to squash them at that point. But I too am wary of combining too many things into one patch and ended up leaning too far the other way.
As I have already queued them up I'd rather not squash them at this point.