RFC gitorious helper
Get series with b4
b4 am 20140110163510.1d2c8d8a@skateVersions newest first
- v1 RFC Latest0 of 2 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 2 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [Buildroot] [RFC PATCH 0/2] gitorious helper
Dear Thomas De Schampheleire,
Quoted 4 lines · Thomas De Schampheleire
1. discuss the situation with the Gitorious people, requesting them to provide a downloadable tarball with the name <package>-<version>.tar.gz (or whichever extension), like the rest of the software world does.
This would be an interesting thing to do, indeed.
Quoted 15 lines
2. accept the fact that the URL cannot be changed, but modify the wget download helper so that it can rename the file after download (clarifying the list of files in dl/)
In the first alternative, the gitorious helper can be a one-liner just as for github, and the .mk files only need to specify
FOO_SITE. In the second alternative, we need to set two variablesFOO_SITEandFOO_SOURCE. In your current patchset, you have done this with one helper that sets both variables. As a result, the usage compared to the github helper is fundamentally different.
For github:FOO_SITE= $(call github,username,package,$(FOO_VERSION)) while for gitorious:
$(call gitorious,username,package,$(FOO_VERSION)
Quoted 4 lines
I don't like this difference, and suggest two alternatives:
A. split the helper in two, so that:FOO_SITE= $(call gitorious-site,username,package,$(FOO_VERSION))FOO_SOURCE= $(call gitorious-version,username,package,$(FOO_VERSION))
I very much prefer this solution. I don't really like the helper that magically defines FOO_SITE and FOO_VERSION.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com