lockdep: Kill held_lock->check and "int check" arg of __lock_acquire()
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest1 patch 8 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | lockdep: Kill held_lock->check and "int check" arg of __lock_acquire()include/ kernel/ | +8 | 6 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/1] lockdep: Kill held_lock->check and "int check" arg of __lock_acquire()
Quoted 11 lines · Ingo Molnar
Quoted 8 lines · Peter Zijlstra
Quoted 3 lines
But what I really can't understans is what "check == 0" means? It seems that in fact it can be 1 or 2? Or, iow, "check == 0" is actually equivalent to "check == 1" ?
Hmm indeed, the comment in
lockdep.hsays 0 means no checks at all, but the code doesn't actually appear to work like that. I'm not sure it ever did or not, I'd have to go dig through history.
Quoted 6 lines
Quoted 4 lines
That said, given the current state it certainly looks like we can remove the check argument.
Ingo?
Agreed.
OK, could you and Peter review the patch?
If it passes the review I'll send another one which changes the callers of lock_acquire(). And trace_lock_acquire() should be trivially updated too.
But could someone please explain me what should lockdep_no_validate actually do? 1704f47b5 "lockdep: Add novalidate class for dev->mutex conversion" doesn't tell which kind of warnings it tries to avoid, and it looks buggy (see another email from me).
Oleg.