Skip to content

RFC Migrate more OMAP DMA code to DMA engine

Tony Lindgren linux-arm-kernel linux-omap 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest0 of 26 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 26 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH RFC 00/26] Migrate more OMAP DMA code to DMA engine
Quoted 30 lines · Russell King - ARM Linux
Quoted 29 lines · Tony Lindgren
Quoted 24 lines · Russell King - ARM Linux
Quoted 14 lines · Tony Lindgren
Quoted 10 lines · Russell King - ARM Linux
Quoted 7 lines · Tony Lindgren
Quoted 1 line · Russell King - ARM Linux

Any news on this?

Sorry for the delay, now getting this:

arch/arm/mach-omap1/dma.c: In function ?omap1_system_dma_init?:
arch/arm/mach-omap1/dma.c:368: error: ?struct omap_dma_dev_attr? has no member named ?chan?

Gah. Next incremental patch:

Thanks, now getting this on omap1:

Quoted 8 lines
# dmesg | grep -i dma
DMA: preallocated 256 KiB pool for atomic coherent allocations
OMAP DMA hardware version 1
DMA capabilities: 0000000c:00000000:01ff:003f:007f
omap-dma-engine omap-dma-engine: invalid resource
omap-dma-engine: probe of omap-dma-engine failed with error -22
mmci-omap mmci-omap.1: unable to obtain TX DMA engine channel 54
mmci-omap mmci-omap.1: unable to obtain RX DMA engine channel 55
Quoted 1 line

Sigh... let's give it the iomem resource then:

OK, looks like adding that makes MMC card detection to fail with:

Quoted 8 lines
Quoted 1 line

DMA timeout with device 55

You should also see a message:

oma-dma-engine omap-dma-engine: failed to get L1 IRQ: ..

which indicates that it's falling back to the old driver for IRQ servicing. Can you confirm that please?

Yes that's correct, here are all the DMA related lines:

DMA: preallocated 256 KiB pool for atomic coherent allocations OMAP DMA hardware version 1
DMA capabilities: 0000000c:00000000:01ff:003f:007f omap-dma-engine omap-dma-engine: failed to get L1 IRQ: -6 omap-dma-engine omap-dma-engine: OMAP DMA engine driver omap-dma-engine omap-dma-engine: allocating channel 0 for 54 omap-dma-engine omap-dma-engine: allocating channel 1 for 55 DMA timeout with device 55

Regards,

Tony

Read the cover letter in its thread