Skip to content

Jean-Francois Moine dri-devel linux-arm-kernel linux-devicetree lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest23 patches 17 repliesIn review
  2. v424 patches 4 repliesSuperseded
  3. v324 patches 23 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/23drm/i2c: tda998x: simplify the i2c read/write functionsdrivers/gpu/drm/i2c/tda998x_drv.c+162 -1600 replies
2/23drm/i2c: tda998x: check more I/O errorsdrivers/gpu/drm/i2c/tda998x_drv.c+43 -143 replies
3/23drm/i2c: tda998x: code cleanupdrivers/gpu/drm/i2c/tda998x_drv.c+7 -60 replies
4/23drm/i2c: tda998x: change probe message origindrivers/gpu/drm/i2c/tda998x_drv.c+14 -50 replies
5/23drm/i2c: tda998x: don't freeze the system at audio startup timedrivers/gpu/drm/i2c/tda998x_drv.c+1 -10 replies
6/23drm/i2c: tda998x: force the page register at startup timedrivers/gpu/drm/i2c/tda998x_drv.c+1 -10 replies
7/23drm/i2c: tda998x: fix bad value in the AIFdrivers/gpu/drm/i2c/tda998x_drv.c+1 -10 replies
8/23drm/i2c: tda998x: use HDMI constantsdrivers/gpu/drm/i2c/tda998x_drv.c+6 -60 replies
9/23drm/i2c: tda998x: don't read write-only registersdrivers/gpu/drm/i2c/tda998x_drv.c+24 -223 replies
10/23drm/i2c: tda998x: free the CEC device on encoder_destroydrivers/gpu/drm/i2c/tda998x_drv.c+2 -00 replies
11/23drm/i2c: tda998x: check the CEC device creationdrivers/gpu/drm/i2c/tda998x_drv.c+2 -00 replies
12/23drm/i2c: tda998x: add DT supportdrivers/gpu/drm/i2c/tda998x_drv.c+22 -00 replies
13/23drm/i2c: tda998x: always enable EDID read IRQdrivers/gpu/drm/i2c/tda998x_drv.c+3 -50 replies
14/23drm/i2c: tda998x: use irq for connection status and EDID readdrivers/gpu/drm/i2c/tda998x_drv.c+104 -90 replies
15/23drm/i2c: tda998x: add DT documentationDocumentation/devicetree/bindings/drm/i2c/tda998x.txt+27 -00 replies
16/23drm/i2c: tda998x: fix the ENABLE_SPACE registerdrivers/gpu/drm/i2c/tda998x_drv.c+1 -10 replies
17/23drm/i2c: tda998x: set the PLL division factor in range 0..3drivers/gpu/drm/i2c/tda998x_drv.c+6 -11 reply
18/23drm/i2c: tda998x: make the audio code more readabledrivers/gpu/drm/i2c/tda998x_drv.c+13 -120 replies
19/23drm/i2c: tda998x: remove the unused variable ca_i2sdrivers/gpu/drm/i2c/tda998x_drv.c+1 -30 replies
20/23drm/i2c: tda998x: add the active aspect in HDMI AVI framedrivers/gpu/drm/i2c/tda998x_drv.c+1 -00 replies
21/23drm/i2c: tda998x: change the frequence in the audio channeldrivers/gpu/drm/i2c/tda998x_drv.c+5 -30 replies
22/23drm/i2c: tda998x: code optimizationdrivers/gpu/drm/i2c/tda998x_drv.c+4 -80 replies
23/23drm/i2c: tda998x: adjust the audio clock divider for S/PDIFdrivers/gpu/drm/i2c/tda998x_drv.c+7 -30 replies

Reviews trailers per patch

11 of 23 patches have a Reviewed-by or Acked-by.

PatchRussell King
1/23A-b T-b
2/23A-b T-b
3/23A-b T-b
4/23A-b T-b
5/23T-b A-b
6/23T-b A-b
7/23T-b A-b
8/23T-b A-b
9/23
10/23T-b A-b
11/23A-b T-b
12/23A-b T-b
13/23
14/23
15/23
16/23
17/23
18/23T-b
19/23T-b
20/23T-b
21/23
22/23
23/23

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 00/23]

This patch set contains various extensions to the tda998x driver:

- simplify the i2c read/write
- code cleanup and fix some small errors
- use global constants
- don't read write-only registers
- add DT support
- use IRQ for connection status and EDID read

- v5
- remarks from Russell King
- free the IRQ on encoder destroy (patch 14)
- fix bad comment (patch 23)
- removal of 'set the video mode from the adjusted value' which was breaking tilcdc (Darren Etheridge)
- use the IRQ trigger type from platform/DT (patch 14)

- v4
- remarks from Russell King (thank you, Russell)
- more comments about the patches
- remove 'fix a NULL pointer dereference'
- get the IRQ number from the i2c client
- remove 'get a better status of the connection'
- split the previous 'fix the ENABLE_SPACE register'
- add asounddef.h variables in 'change the frequence in the audio channel'
- add 'always enable EDID read IRQ'
- remove audio changes which will be in a next patch set about information exchanges with the audio subsystem
- v3
- remarks from Russell King
- more comments about the patches
- change variable name instead of copy (patch 7)
- add 'fix bad value in the AIF' (patch 8)
- add 'fix a NULL pointer dereference' (patch 13)
- add 'add DT documentation' (patch 16)
- remove 'use the tda998x video format when cea mode'
- remove 'change the video quantization
- remove 'fix the value of the TBG_CNTRL_1 register'
- remove 'tda998x: move the TBG_CNTRL_0 register setting'
- change fields of the register AIP_CLKSEL (patch 19)
- remove 'adjust the audio CTS to the mode clock'
- don't put a comment between field definition (patch 23)
- some more remarks may be found in the patches 10, 14, 15
- removal of the tda codec interface which will be the subject
of an other patch series
- v2
- decompose patches with different topics
- fix some bad i2c register values
- add audio codec interface

Jean-Francois Moine (23):
drm/i2c: tda998x: simplify the i2c read/write functions drm/i2c: tda998x: check more I/O errors
drm/i2c: tda998x: code cleanup
drm/i2c: tda998x: change probe message origin drm/i2c: tda998x: don't freeze the system at audio startup time drm/i2c: tda998x: force the page register at startup time drm/i2c: tda998x: fix bad value in the AIF
drm/i2c: tda998x: use HDMI constants
drm/i2c: tda998x: don't read write-only registers drm/i2c: tda998x: free the CEC device on encoder_destroy drm/i2c: tda998x: check the CEC device creation drm/i2c: tda998x: add DT support
drm/i2c: tda998x: always enable EDID read IRQ drm/i2c: tda998x: use irq for connection status and EDID read drm/i2c: tda998x: add DT documentation
drm/i2c: tda998x: fix the ENABLE_SPACE register drm/i2c: tda998x: set the PLL division factor in range 0..3 drm/i2c: tda998x: make the audio code more readable drm/i2c: tda998x: remove the unused variable ca_i2s drm/i2c: tda998x: add the active aspect in HDMI AVI frame drm/i2c: tda998x: change the frequence in the audio channel drm/i2c: tda998x: code optimization
drm/i2c: tda998x: adjust the audio clock divider for S/PDIF

 .../devicetree/bindings/drm/i2c/tda998x.txt        |  27 +
 drivers/gpu/drm/i2c/tda998x_drv.c                  | 609 +++++++++++++--------
 2 files changed, 416 insertions(+), 220 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/drm/i2c/tda998x.txt
Signature · 1 line
1.9.rc1