Skip to content

fs: ufs: Remove unused pointer

Christian Engelmayer linux-fsdevel lkml 1 version New

Get series with b4
b4 am 20140211012012.6384d52f@spike

Versions newest first

  1. v1 Latest3 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3fs: ufs: Remove unused ufs_super_block_first pointerfs/ufs/balloc.c fs/ufs/ialloc.c fs/ufs/super.c+0 -180 replies
2/3fs: ufs: Remove unused ufs_super_block_second pointerfs/ufs/super.c+0 -20 replies
3/3fs: ufs: Remove unused ufs_super_block_third pointerfs/ufs/super.c+0 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] fs: ufs: Remove unused pointer

This is a cleanup throughout ufs regarding pointers that are set up, but no longer used in the affected functions. The ubh_get_usb_(first|second|third) macros found in the changesets all resolve to

static inline void *get_usb_offset(struct ufs_sb_private_info *uspi,
unsigned int offset)

   {
           unsigned int index;

           index = offset >> uspi->s_fshift;
           offset &= ~uspi->s_fmask;
           return uspi->s_ubh.bh[index]->b_data + offset;

}

and differ in the passed offset value. get_usb_offset() does not alter the passed ufs_sb_private_info struct. Those calls can be thus removed safely where the return value is not further used.

The series applies against v3.14-rc2 and is compile tested.

Christian Engelmayer (3):
fs: ufs: Remove unused ufs_super_block_first pointer.
fs: ufs: Remove unused ufs_super_block_second pointer.
fs: ufs: Remove unused ufs_super_block_third pointer.

 fs/ufs/balloc.c | 12 ------------
 fs/ufs/ialloc.c |  4 ----
 fs/ufs/super.c  |  6 ------
 3 files changed, 22 deletions(-)
Signature · 1 line
1.8.3.2