Skip to content

primecell: make correct clock parsing possible

Mark Rutland linux-arm-kernel linux-devicetree 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 7 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 7 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] primecell: make correct clock parsing possible
Quoted 9 lines · Russell King - ARM Linux
Quoted 7 lines · Mark Rutland

These patches attempt to harmonize the bindings and the drivers with what's in use today, in a backwards compatible fashion, relieving us of our present Kafkaesque nightmare. Each peripheral's clock(s) are given explicit names which can be used, though code will fall back to the existing behaviour if said names are not provided. Additionally the currently unmet ordering requirement of apb_pclk is dropped, given all existing that code requires this to be named anyway.

Quoted 5 lines

The reason why these clocks ended up with NULL names was to force the issue that clocks shall not be named solely by their connection IDs, which was a major problem before DT. Now that we have DT, I'm happier to reinstate the names, but I think we should just reinstate the names we had previously. That should be in the git history.

Good to know, that sounds fine to me.

Quoted 3 lines

The down-side is those names are all in capitals - but they were named after the signal name(s) given in the Primecell documentation.

As long as we have standardised names I'm not too worried about which case they happen to be in, and matching the documentation seems sensible. The pl050 driver expects "KMIREFCLK" already, so it would be in keeping with (as far as I can tell) the only Primecell driver currently requesting a clock by name.

I'll prepare a v2 shortly.

Cheers,
Mark.