Input: Support in the elantech driver of the trackpoint present on for instance Lenovo L530
Status from this message: Applied, thank you.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest posting 2/22 patches 3 repliesApplied
- v4 posting 1/22 patches 2 repliesSuperseded
- v32 patches 2 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 1 patch | 5 replies | Superseded | |
| v1 | 1 patch | 1 reply | Superseded |
Changes in v4 from the cover letter
* Patch1: added (correct) error after input_allocate_device failure in elantech_init()
* Patch2: added more explanation to the why
Patches in v4 posting 2/2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | elantech: Add support for trackpoint found on some v3 modelsdrivers/ drivers/ | +121 | 3 replies | |
| 2/2 | elantech: Call psmouse_reset when elantech probe failsdrivers/ | +1 | 1 reply |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Hans de Goede | David Herrmann |
|---|---|---|
| 1/2 | R-b | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH RESEND v4 0/2] Input: Support in the elantech driver of the trackpoint present on for instance Lenovo L530
Hi Dmitry,
I posted these 2 months ago, but haven't seen any comments from you. Could you please review these ?
Thanks,
Ulrik
Patch 1 adds support for trackpoint on elantech driver for v3 models. Patch 2 adds a psmouse_reset when the elantech probes fails. Patch 2 depends on Patch 1.
Changes since v3:
* Patch1: added (correct) error after input_allocate_device failure in elantech_init()
* Patch2: added more explanation to the why
Changes since v2:
* psmouse_reset change is now moved to a separate patch
* comments/white spaces/newlines cleanup
* Unexpected trackpoint message warning now only printed once
* removed some unnecessary casts
* Deleted etd->trackpoint_present and use instead etd->tp_dev to indicate the presence of a trackpoint
* Propagate the error when elantech_init fails
Changes since v1:
* New patch now with reference to 3.14rc1
* Added etd->trackpoint_present to indicate presence of trackpoint (based on MSB of etd->capabilities[0])
* trackpoint will only be registered now when MSB of etd->capabilities[0] is set; got confirmation that this is the indicator of trackpoint
* Added input_unregister_device/input_free_device in elantech_disconnect()
* Fixed a bug in cleaning up when elantech_init fails
* Rename commit to be more specific (now also applicable to future elantech v3 models with trackpoint)
* input device name 'TPPS/2 IBM TrackPoint' changed to
'Elantech PS/2 TrackPoint', this patch is not ibm/lenovo specific!
* dev2 renamed to tp_dev to indicate that this is the trackpoint device
* etd->phys renamed to etd->tp_phys
* Added Lenovo 530 and Fujitsu H730 to the laptop list because those are now also known.
* Added psmouse_reset at the end of elantech_init when it fails
* Added warning when trackpoint packets are received with no trackpoint detected
The patches are also available from:
https://github.com/ulrikdb/linux/commit/53d8424bc2143d34c2be76064892079fe1917a9e
https://github.com/ulrikdb/linux/commit/cf12fcc6cdf51a7aad48d056750478aecd9d7eca
Ulrik De Bie (2):
elantech: Add support for trackpoint found on some v3 models
elantech: Call psmouse_reset when elantech probe fails
drivers/input/mouse/elantech.c | 123 +++++++++++++++++++++++++++++++++++++++-- drivers/input/mouse/elantech.h | 3 + 2 files changed, 122 insertions(+), 4 deletions(-)
Signature · 1 line
2.1.0.rc1