Skip to content

target-ppc: htab fixes (V2)

Greg Kurz qemu-devel 1 version Applied

Status from this message: Thanks, applied to ppc-next.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 4 patches 1 replyApplied

Patches in v1 Applied

None of the 4 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/4] target-ppc: htab fixes (V2)
Quoted 18 lines · On Mon, 17 Feb 2014 14:22:14 +0100 Greg Kurz <[email protected]> wrote:

Hi,

This is a new tentative for the patches 2/5 to 5/5 from the "target-ppc:
Add support for dumping guest memory using qemu gdb server" patchset:

https://lists.nongnu.org/archive/html/qemu-ppc/2014-01/msg00380.html

All patches have been rebased on the current ppc-next head (72c798d7dccc).

To ensure proper bisectability, the following was verified for each individual patch:
•- 32 and 64 bit build of ppc-softmmu and ppc64-softmmu (fedora 19 ppc64) •- 64 bit pseries guest with KVM on a POWER7 host (fedora 19 ppc64) •- 64 bit pseries guest with 64 bit TCG on a x86_64 host (fedora 19 ppc64) •- 64 bit pseries guest with 32 bit TCG on a x86_64 host (fedora 19 ppc64) •- 32 bit mac99 guest with 64 bit TCG on a x86_64 host (wheezy ppc) •- 32 bit mac99 guest with 32 bit TCG on a x86_64 host (wheezy ppc)

Quoted 4 lines

Alex,

This should address all the requirements you expressed in your last mail. Please tell me if something is missing.

Alex,

I have added the 32 bit build with KVM enabled to catch the remaining build breaks:

target-ppc/kvm.c: In function 'kvmppc_hash64_read_pteg':
target-ppc/kvm.c:1977:12: error: cast from pointer to integer of different size
[-Werror=pointer-to-int-cast]
target-ppc/kvm.c: In function 'kvmppc_hash64_free_pteg':
target-ppc/kvm.c:1990:82: error: cast to pointer from integer of different size
[-Werror=int-to-pointer-cast]

I have folded the fix into patch 2/4.

I have also fixed the SoB mess, and rebased on the current ppc-next.

Hope this time, it is okay ! :)

Best Regards.

---

Aneesh Kumar K.V (4):
target-ppc: Fix htab_mask calculation
target-ppc: Fix page table lookup with kvm enabled
target-ppc: Change the hpte store API
target-ppc: Update ppc_hash64_store_hpte to support updating in-kernel htab

 hw/ppc/spapr.c           |    9 ++++
 hw/ppc/spapr_hcall.c     |   81 ++++++++++++++++++++++---------------
 target-ppc/cpu.h         |    1 
 target-ppc/kvm.c         |   94 ++++++++++++++++++++++++++++++++++++++++++-
 target-ppc/kvm_ppc.h     |   29 +++++++++++++
 target-ppc/machine.c     |   11 +++--
 target-ppc/misc_helper.c |    4 +-
 target-ppc/mmu-hash64.c  |  101 +++++++++++++++++++++++++++++++++++++++-------
 target-ppc/mmu-hash64.h  |   47 ++++++++-------------
 target-ppc/mmu_helper.c  |    3 +
 10 files changed, 294 insertions(+), 86 deletions(-)
Signature · 1 line
Greg