Skip to content

tracing: Request for acks on fixing tracepoint code

Steven Rostedt lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4tracing: Fix event header writeback.h to include tracepoint.hinclude/trace/events/writeback.h+1 -00 replies
2/4tracing: Fix event header migrate.h to include tracepoint.hinclude/trace/events/migrate.h+2 -01 reply
3/4tracing/module: Remove include of tracepoint.h from module.hinclude/linux/module.h+0 -13 replies
4/4tracing: Do not add event files for modules that fail tracepointsinclude/linux/tracepoint.h kernel/trace/trace_events.c kernel/tracepoint.c+12 -10 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchMel GormanRusty Russell
1/4
2/4A-b
3/4A-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFA][PATCH 0/4] tracing: Request for acks on fixing tracepoint code

[ Request for Acks ]

Due to module tainting, we have tracepoints that silently do not work. That will be solved another way. But the trace event infrastructure should not be created for tainted modules. That is, the debugfs files should not exist for them.

By moving the tracepoint module taint test into tracepoint.h, we can reuse that same test when creating the module tracepoint events.

Note, I had to remove the tracepoint.h include from module.h as there was nothing in module.h that required tracepoint.h, but this broke a couple of event files (migrate.h and writeback.h) because they did not include tracepoint.h, and were just lucky that it was included by module.h.

Steven Rostedt (Red Hat) (4):
tracing: Fix event header writeback.h to include tracepoint.h
tracing: Fix event header migrate.h to include tracepoint.h tracing/module: Remove include of tracepoint.h from module.h
tracing: Do not add event files for modules that fail tracepoints

----

 include/linux/module.h           |  1 -
 include/linux/tracepoint.h       |  7 +++++++
 include/trace/events/migrate.h   |  2 ++
 include/trace/events/writeback.h |  1 +
 kernel/trace/trace_events.c      |  4 ++++
 kernel/tracepoint.c              |  2 +-
 6 files changed, 23 insertions(+), 21 deletions(-)