RFC PCI: imx6: fixup for add-in card IRQ mismapping
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest1 of 3 patches 0 repliesNew
1 of 3 patches is in this archive. The cover letter announces 3.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | PCI: designware: add legacy PCI interrupt mapping | +0 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC PATCH 0/3] PCI: imx6: fixup for add-in card IRQ mismapping
Quoted 37 lines · Jingoo Han
Quoted 15 lines · Tim Harvey
Quoted 6 lines · Jingoo Han
Quoted 4 lines · Tim Harvey
An add-in card used on the Ventana IMX6 SoC based family of boards has a TI XIO2001 PCIe-to-PCI bridge where the INTA/B/C/D mappings between the bridge and the four mini-PCI slots are swapped (INTD/C/B/A).
Quoted 7 lines
(+cc Marek Vasut, Pratyush Anand, Kishon Vijay Abraham I, Mohit KUMAR DCG)
This problem happens from the 'Board', not a 'SoC'.
'TI XIO2001 PCIe-to-PCI bridge' is not a 'SoC'. 'pci-imx6.c' is the driver for 'IMX6 PCI IP', not for 'IMX6 SoC based board'. Isn't it?Quoted 4 lines
Jingoo,
Correct, this is an issue in the way the XIO2001 was hooked up to the PCI slots, so it should be viewed as a board issue.
(+CC Arnd Bergmann)
Then, this board fixup code should NOT be placed in '
./drivers/pci/host/' side.Quoted 10 lines
Quoted 2 lines
Then, the workaround code for board problem should NOT be included to '
./drivers/pci/host/' side.I would agree, but to overcome this sort of interrupt mapping issue one would need to either implement a custom swizzle or perhaps a custom
map_irqand both of those are hooked into the pcie driver core.Do you have any suggestions on where/how I would better hook into
those?
Quoted 7 lines
Anyway, 'TI XIO2001 PCIe-to-PCI bridge' chip on the board is the culprit. So, the board specific side is a good place. For instance,
./arch/arm/mach-imx/I don't know how to handle this problem.
But, there is no reason that 'pcie-designware.c' should take a care of the board specific issue.
Can you not just supply the INTA...INTD IRQ numbers in reverse order via DT for this board ?