Skip to content

Watchdog on Armada 375 SoC

Ezequiel Garcia linux-arm-kernel linux-watchdog 1 version New

Get series with b4
b4 am 20140228150925.GC24805@localhost

Versions newest first

  1. v1 Latest0 of 2 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] Watchdog on Armada 375 SoC
Quoted 4 lines · Jason Gunthorpe
Quoted 2 lines · Ezequiel Garcia

Here we found both the above RSTOUT:

Quoted 8 lines
Quoted 2 lines

1. It has the same dedicated register as A370/XP (0x20704)
2. Also has a bit in the shared RSTOUT register (0x18254)

Unless you know otherwise I think the same risk exists, RSTOUT could be (or become) internally asserted when you unmask the bit in the control register that drives the pin, which says the watchdog driver should control to it.

I guess it's also possible to have the system-controller ensure the watchdog is fully stopped, before unmasking the shared RSTOUT.

However, it seems it would be too ugly and hackish.

Quoted 11 lines
Quoted 7 lines
	watchdog-timer at 20300 {
		compatible = "marvell,orion-wdt";
		reg = <0x20300 0x28
		       {shared RSOUT} 0x4
		       0x0 0x0>;
	};

I wouldn't have the 0x0, if you want to go this way, just make the 375 compatible string require a 3 entry reg.

Yes, this sounds like the right thing to do. It means we need to also have per-SoC hooks for stop() and is_enabled(), but it's the price to pay for changing the register semantic: the shared RSTOUT has unmask/mask semantics on A375, while it's enable/disable on Kirkwood and friends.

Let me cook a new patch.

Signature · 3 lines
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com