Skip to content

lua

Thomas Petazzoni buildroot 3 versions – In review

Get series with b4
b4 am 20140419235838.1fb6d8db@skate

Versions newest first · linked by author and title

  1. v3 Latest posting 2/20 of 8 patches 3 repliesIn review
  2. v3 posting 1/22 of 8 patches 0 repliesSuperseded
  3. v10 of 24 patches 0 repliesSuperseded

Patches in v3 posting 2/2 No applies recorded yet

None of the 8 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [Buildroot] [lua V3 0/8] lua

Fran?ois,

Quoted 22 lines · Thomas Petazzoni
Quoted 7 lines

Francois Perrad (8):
luajit: refactor without dont-strip.patch
luajit: refactor without shared-lib.patch
luajit: handles BR2_PREFER_STATIC_LIB
luajit: add host variant
luainterpreter: add host variant
luarocks: allow to work with host-luainterpreter

For all these patches, and especially the last three ones, I want commit logs. I really do appreciate _a lot_ all the work you're doing on Lua and Perl, it's really awesome. And I really mean it. But you need to work on improving your commit logs. For now, we have no idea *why* you're doing these changes.

All the other core developers are doing efforts to write long, descriptive commit logs, and experience has shown that they are immensely useful 6 or 12 months later when we got back in the Git history to understand why things were done. Look at what they do, and follow the basic rule of thumb that any non-trivial patch should have at least 2 or 3 paragraphs in its commit log explaining *why* the change is being made.

Quoted 3 lines

At this point, I have no idea what you are doing. I presume patches 4 and 5 are preparations for patch 6, but I don't understand what patch 6 is doing, and nowhere it is mentioned why patches 4 and 5 are needed.

Any news about these patches? From this series, we still have patches 4, 5, 6 and 8 pending in patchwork. Could you take into account the comments that have been made (mainly the strong need for more detailed commit logs), and resend updated versions on top of master?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Read the cover letter in its thread