genirq: Sanitize irq_set_affinity callbacks
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 patches 13 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | ia64: Validate online cpus in irq_set_affinity() callbacksarch/ arch/ arch/ | +4 | 0 replies | |
| 2/5 | mips: Validate online cpus in irq_set_affinity() callbacksarch/ arch/ | +2 | 2 replies | |
| 3/5 | parisc: Validate online cpus in irq_set_affinity() callbacksarch/ | +1 | 0 replies | |
| 4/5 | xen: Validate online cpus in set_affinitydrivers/ | +1 | 2 replies | |
| 5/5 | irqchip: armanda: Sanitize set_irq_affinity()drivers/ | +5 | 9 replies |
Reviews trailers per patch
2 of 5 patches have a Reviewed-by or Acked-by.
| Patch | David Vrabel | Gregory CLEMENT |
|---|---|---|
| 1/5 | ||
| 2/5 | ||
| 3/5 | ||
| 4/5 | R-b R-b | |
| 5/5 | A-b T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [patch 0/5] genirq: Sanitize irq_set_affinity callbacks
In my last tree wide sweep of irq controller related oddities I discovered that some controllers have an broken implementation versus selecting a single target cpu from the given cpu mask.
The core merily guarantees that at least one of the cpus in the mask is online.
If the controller callback does not restrict the search for a single target to the online cpus it might run into the following situation:
Assume 4 cores online: online mask = 0x0f
Offline Core 1 online mask = 0x0d
Set affinity to 0xe is valid due to online mask 0xd
cpumask_first(0xe) picks core 1, which is offlineThe following series takes care of this. The patches should be tagged stable if there are no objections.
I'm pondering to extend the core functionality to select a target cpu before calling into irq_set_affinity() to prevent future copy and paste failures and get rid of all the duplicated code.
Thanks,
tglx