Skip to content

ath9k|ath9k_htc: move dups to common-beacon

John W. Linville ath9k-devel linux-wireless 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 23 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 23 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [ath9k-devel] [PATCH 00/23] ath9k|ath9k_htc: move dups to common-beacon
Quoted 11 lines · Oleksij Rempel

Am 07.03.2014 11:18, schrieb Sujith Manoharan:

Quoted 7 lines
Quoted 3 lines · Oleksij Rempel

Last response was about initvals, my patch set affect only beacon code. Since i don't plan to rewrite ath9k_htc from scratch, i would assume it will be better to continue this periodic clean work.

I didn't review the patches, but someone else needs to make sure that nothing is broken in ath9k.

I use this code one week ind STA mode. But if you need more directed alternate testing, who is good candidate for this work?

I applied the series and attempted a build. But...

CC drivers/net/wireless/ath/ath9k/tx99.o
In file included from include/linux/bitops.h:33:0,

                 from include/linux/kernel.h:10,
                 from include/linux/skbuff.h:17,
                 from include/linux/if_ether.h:23,
                 from include/linux/etherdevice.h:25,
                 from drivers/net/wireless/ath/ath9k/ath9k.h:20,
                 from drivers/net/wireless/ath/ath9k/tx99.c:17:
drivers/net/wireless/ath/ath9k/tx99.c: In function ?ath9k_tx99_init?:
drivers/net/wireless/ath/ath9k/tx99.c:111:15: error: ?SC_OP_INVALID? undeclared (first use in this function)
  if (test_bit(SC_OP_INVALID, &sc->sc_flags)) {
               ^
/home/linville/git/wireless-next/arch/x86/include/asm/bitops.h:338:25: note: in definition of macro ?test_bit?
  (__builtin_constant_p((nr))  \
                         ^
drivers/net/wireless/ath/ath9k/tx99.c:111:15: note: each undeclared identifier is reported only once for each function it appears in
  if (test_bit(SC_OP_INVALID, &sc->sc_flags)) {
               ^
/home/linville/git/wireless-next/arch/x86/include/asm/bitops.h:338:25: note: in definition of macro ?test_bit?
  (__builtin_constant_p((nr))  \
                         ^
drivers/net/wireless/ath/ath9k/tx99.c:111:33: error: ?struct ath_softc? has no member named ?sc_flags?
  if (test_bit(SC_OP_INVALID, &sc->sc_flags)) {
                                 ^
/home/linville/git/wireless-next/arch/x86/include/asm/bitops.h:339:30: note: in definition of macro ?test_bit?
   ? constant_test_bit((nr), (addr)) \
                              ^
drivers/net/wireless/ath/ath9k/tx99.c:111:33: error: ?struct ath_softc? has no member named ?sc_flags?
  if (test_bit(SC_OP_INVALID, &sc->sc_flags)) {
                                 ^
/home/linville/git/wireless-next/arch/x86/include/asm/bitops.h:340:30: note: in definition of macro ?test_bit?
   : variable_test_bit((nr), (addr)))
                              ^

make[3]: *** [drivers/net/wireless/ath/ath9k/tx99.o] Error 1 make[2]: *** [drivers/net/wireless/ath/ath9k] Error 2 make[1]: *** [drivers/net/wireless/ath] Error 2
make: *** [drivers/net/wireless/] Error 2

I'll be backing this out for now...

John

Signature · 2 lines
John W. Linville		Someday the world will need a hero, and you
linville at tuxdriver.com			might be all we have.  Be ready.

Read the cover letter in its thread