(Was: pppd service crash in linux-3.13.6)
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | exit: call disassociate_ctty() before exit_task_namespaces()kernel/ | +2 | 0 replies | |
| 2/2 | exit: move check_stack_usage() to the end of do_exit()kernel/ | +1 | 0 replies |
Reviews trailers per patch
None of the 2 patches has a Reviewed-by or Acked-by.
| Patch | Peter Hurley |
|---|---|
| 1/2 | Investigated-by |
| 2/2 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] (Was: pppd service crash in linux-3.13.6)
Quoted 11 lines · Peter Hurley
Quoted 5 lines · Oleg Nesterov
But it can't even know who called
call_usermodehelper(). Besides,cgroup_release_agent()usesUMH_WAIT_EXEC, so the caller can continue and disappear completely before the usermode process has any chance to do something.I'm just hypothesizing potential breakage, since the order of teardown is sensitive to changes, and I didn't do a complete audit of all the possibilities.
Yes, I understand your concerns. Still I do not see how cgroup_exit() can depend on tty/namespace.
Quoted 1 line
If you feel strongly about moving
disassociate_tty(), I won't object.
It is not that I feel really strongly... just in looks better to me. If nothing else:
1. If we actually can not do disassociate_ctty() before, say, cgroup_exit(), then we should understand and document the reason.
2. task_work_add() can have more users in drivers/tty which can be triggered by disassociate_tty() paths. So I think it would be nice to call it before task_work_exit().
2/2 is offtopic and hopefully trivial.
Oleg.