scsi/NCR5380: fix debugging macros and #include structure
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest12 patches 9 repliesIn review
- v112 patches 14 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | scsi/NCR5380: remove unused BOARD_NORMAL and BOARD_NCR53C400drivers/ drivers/ drivers/ +1 more | +0 | 0 replies | |
| 2/12 | scsi/NCR5380: remove redundant HOSTS_C macro testsdrivers/ drivers/ drivers/ +2 more | +0 | 0 replies | |
| 3/12 | scsi/NCR5380: remove old CVS keywordsdrivers/ drivers/ drivers/ +7 more | +0 | 0 replies | |
| 4/12 | scsi/NCR5380: use NCR5380_dprint() instead of NCR5380_print()drivers/ | +1 | 0 replies | |
| 5/12 | scsi/NCR5380: fix build failures when debugging is enableddrivers/ drivers/ | +10 | 0 replies | |
| 6/12 | scsi/NCR5380: fix dprintk macro usage and definitiondrivers/ drivers/ drivers/ | +67 | 0 replies | |
| 7/12 | scsi/NCR5380: adopt NCR5380_dprint() and NCR5380_dprint_phase()drivers/ drivers/ | +22 | 1 reply | |
| 8/12 | scsi/NCR5380: adopt dprintk()drivers/ drivers/ drivers/ | +134 | 1 reply | |
| 9/12 | scsi/NCR5380: fix and standardize NDEBUG macrosdrivers/ drivers/ drivers/ +6 more | +20 | 0 replies | |
| 10/12 | scsi/NCR5380: remove unused macro definitionsdrivers/ drivers/ | +0 | 1 reply | |
| 11/12 | scsi/NCR5380: reduce depth of sun3_scsi nested includesdrivers/ drivers/ drivers/ | +5 | 0 replies | |
| 12/12 | scsi/NCR5380: merge sun3_scsi_vme.c into sun3_scsi.cdrivers/ drivers/ | +171 | 0 replies |
Reviews trailers per patch
3 of 12 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Sam Creasey | Michael Schmitz |
|---|---|---|
| Series | A-b | |
| 1/12 | ||
| 2/12 | ||
| 3/12 | ||
| 4/12 | ||
| 5/12 | ||
| 6/12 | ||
| 7/12 | A-b | |
| 8/12 | A-b | |
| 9/12 | ||
| 10/12 | A-b | |
| 11/12 | ||
| 12/12 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 00/12] scsi/NCR5380: fix debugging macros and #include structure
This patch series addresses several issues with NCR5380 drivers:
1. The complex network of #include directives.
2. Three inconsistent implementations of the core driver all attempting to share the same macro definitions in NCR5380.h.
3. Broken debugging code.
In the past these issues have led to compiler warnings and ugly hacks to fix build failures.
This patch series fixes the debugging code by reducing the divergence between the various core driver implementations.
The final two patches in the series further reduce divergence by refactoring sun3_scsi.c and sun3_scsi_vme.c so that they follow the same structure as the other NCR5380 drivers.
By the end of this patch series over 800 net lines of code have been removed. This is mostly duplicated code that's easily eliminated once the debugging code is made consistent (and some dead code is removed).
Better uniformity and less duplication should assist future work such as modernization and trivial clean-up.
To make code review easier I've tried to keep these patches succinct and free of extraneous changes. Though I did run checkpatch.pl, I've ignored whitespace issues in existing code. I will send separate patches for whitespace clean-up of NCR5380 drivers.
All NCR5380 drivers have been compile-tested with this patch series:
arm/cumana_1.c
arm/oak.c
atari_scsi.c
dmx3191d.c
dtc.c
g_NCR5380.c
g_NCR5380_mmio.c
mac_scsi.c
pas16.c
sun3_scsi.c
sun3_scsi_vme.c
t128.c
I've successfully regression tested this patch series using mac_scsi on a PowerBook 180. The debugging macros are now usable again.