wait: introduce WQ_FLAG_EXCLUSIVE_HEAD
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 2 repliesIn review
Changes from the cover letter
1. I decided it would be better to change __wait_event() to accept wait.flags right now. This looks better in any case to me, and otherwise we need to introduce the __wait_exclusive_enum.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | wait: turn "bool exclusive" arg of __wait_event() into wflagsinclude/ | +8 | 0 replies | |
| 2/2 | wait: introduce WQ_FLAG_EXCLUSIVE_HEADinclude/ kernel/ | +26 | 0 replies |
Reviews trailers per patch
None of the 2 patches has a Reviewed-by or Acked-by.
| Patch | Peng Tao |
|---|---|
| 1/2 | |
| 2/2 | Requested-by |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] wait: introduce WQ_FLAG_EXCLUSIVE_HEAD
Quoted 2 lines · Oleg Nesterov
OK, I'll try to test/cleanup/resend tomorrow.
Cough. Still un-tested, sorry. I will test it somehow and report, but I'd like to send this for review right now.
Because I simply can't decide what the new flag should actually do, so please ack/nack the semantics/naming at least.
Changes:
1. I decided it would be better to change __wait_event() to accept wait.flags right now. This looks better in any case to me, and otherwise we need to introduce the __wait_exclusive_enum.
The change looks trivial (both actually), please tell me if you think it doesn't deserve a separate patch.
2. I won't insist, but WQ_FLAG_EXCLUSIVE_HEAD can be used without WQ_FLAG_EXCLUSIVE.
Unlikely this can be useful, but it looks more natural this way. Otherwise we need to add another check to ensure that WQ_FLAG_EXCLUSIVE_HEAD can't come alone.
However, perhaps this means the new flag needs another name. I agree in advance with any.
Oleg.