Documentation cleanup
Get series with b4
b4 am 20140329112838.0bee5010@skateVersions newest first
- v1 Latest0 of 9 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 9 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [Buildroot] [PATCH 0/9] Documentation cleanup
Dear Jerzy Grzegorek,
Quoted 10 lines · Jerzy Grzegorek
Regarding the "may be added", I agree.
I proposed this change because I saw on mailing list both cases of submitting patch series introduced by a cover letter:* "in addition" case:
[Patch vX 0/Y] ... [Patch vX 1/Y] ... ... [Patch vX Y/Y] ...
Quoted 5 lines
* "instead" case:
[Patch vX 0/Y] ... [Patch 1/Y] ... ... [Patch Y/Y] ...
To me, this second variant is wrong. This is because the cover letters are not recorded by patchwork, so if the version is not mentioned in the title of each individual patch, patchwork will not have the information of the version of the patches.
Quoted 4 lines
So maybe it should be:
"Note that when your patch series is introduced by a cover letter, a patch version should be added to the cover letter in addition to the individual commits."
But is it really necessary? Such a wording seems to imply that the contributor would have to do this manually, while the contributor should instead simply use "git format-patch --subject-prefix", which does just the right thing.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com