Skip to content

uprobes/x86: preparations to fix the reprel jmp/call handling.

Oleg Nesterov lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 11 repliesIn review
  2. v17 patches 23 repliesSuperseded

Changes from the cover letter

- "Conditionalize the usage of handle_riprel_insn()" is moved after "Introduce uprobe_xol_ops and arch_uprobe->ops" to make the reason more clear, update the changelog.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9uprobes: Kill UPROBE_SKIP_SSTEP and can_skip_sstep()kernel/events/uprobes.c+2 -210 replies
2/9uprobes/x86: Fold prepare_fixups() into arch_uprobe_analyze_insn()arch/x86/kernel/uprobes.c+47 -630 replies
3/9uprobes/x86: Kill the "ia32_compat" check in handle_riprel_insn(), remove "mm" argarch/x86/kernel/uprobes.c+3 -70 replies
4/9uprobes/x86: Gather "riprel" functions togetherarch/x86/kernel/uprobes.c+53 -650 replies
5/9uprobes/x86: move the UPROBE_FIX_{RIP,IP,CALL} code at the end of pre/post hooksarch/x86/kernel/uprobes.c+14 -160 replies
6/9uprobes/x86: Introduce uprobe_xol_ops and arch_uprobe->opsarch/x86/include/asm/uprobes.h arch/x86/kernel/uprobes.c+74 -406 replies
7/9uprobes/x86: Conditionalize the usage of handle_riprel_insn()arch/x86/kernel/uprobes.c+2 -40 replies
8/9uprobes/x86: Send SIGILL if arch_uprobe_post_xol() failsarch/x86/kernel/uprobes.c kernel/events/uprobes.c+19 -50 replies
9/9uprobes/x86: Teach arch_uprobe_post_xol() to restart if possiblearch/x86/kernel/uprobes.c+11 -42 replies

Reviews trailers per patch

7 of 9 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMasami HiramatsuDavid A. LongJim KenistonSrikar Dronamraju
SeriesR-b A-b
1/9R-b R-b R-b A-b
2/9R-b R-b A-b
3/9R-b R-b A-b
4/9R-b R-b
5/9R-b R-b A-b
6/9R-b R-b
7/9R-b
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/9] uprobes/x86: preparations to fix the reprel jmp/call handling.

Hello.

Changes:

- "Conditionalize the usage of handle_riprel_insn()" is moved after "Introduce uprobe_xol_ops and arch_uprobe->ops" to make the reason more clear, update the changelog.

Masami, I hope this addresses your comments? I would be happy to add your ack into 6/9 and 7/9 ;)

- update the comment in 4/9, pointed out by Jim.

- fix some typos in the changelogs/naming

- 8-9 are new (the same I sent yesterday)

Since the changes in 1-7 are purely cosmetic, I preserved the acks I got.

Srikar, you acked 1, 2, 3, and 5 but didn't comment other changes. Please let me know if I missed your emails. Do you agree with this series or you have some concerns?

Now let me send the draft RFC patch which fixes the "call" handling...

Oleg.

 arch/x86/include/asm/uprobes.h |    7 +-
 arch/x86/kernel/uprobes.c      |  360 ++++++++++++++++++++--------------------
 kernel/events/uprobes.c        |   31 +---
 3 files changed, 199 insertions(+), 199 deletions(-)