uprobes/x86: fix the handling of relative jmp's/call's
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest15 patches 0 repliesNew
- v2 RFC6 patches 11 repliesSuperseded
- v1 RFC6 patches 32 repliesSuperseded
Patches in v3 No applies recorded yet
Reviews trailers per patch
All 15 patches have a Reviewed-by or Acked-by.
| Patch | Masami Hiramatsu | Jim Keniston | Srikar Dronamraju | David A. Long |
|---|---|---|---|---|
| 1/15 | R-b | R-b | A-b | R-b |
| 2/15 | R-b | R-b | A-b | |
| 3/15 | R-b | R-b | A-b | |
| 4/15 | R-b | R-b | ||
| 5/15 | R-b | R-b | A-b | |
| 6/15 | R-b | R-b | ||
| 7/15 | R-b | R-b | ||
| 8/15 | R-b | R-b | ||
| 9/15 | R-b | R-b | ||
| 10/15 | R-b | |||
| 11/15 | R-b | |||
| 12/15 | R-b | |||
| 13/15 | R-b | |||
| 14/15 | R-b | |||
| 15/15 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v3 00/15] uprobes/x86: fix the handling of relative jmp's/call's
Hello.
OK, let me resend everything. This is what I am going to add to my tree and ask Ingo to pull. I am still testing this all, seems to work so far.
Changes:
01-09: No changes, added the acks from Masami.
09-15: Updated the changelogs, the comments in 13/15, plus the
following renames:
- s/ttt/branch/
- s/disp/offs/
- s/_clear_displacement/_clear_offset/
No changes in compiled code, I preserved the acks from Jim.
Quoted 1 line
From 13/15:
Note: as Denys Vlasenko pointed out, amd and intel treat "callw" (0x66 0xe8) differently. This patch relies on lib/insn.c and thus implements the intel's
behaviour: 0x66 is simply ignored. Fortunately nothing sane should ever use this insn, so we postpone the fix until we decide what should we do; emulate or not, support or not, etc.
Yes. Lets discuss (and fix?) this separately, I'll write another email.
Any objections?
Oleg.
arch/x86/include/asm/uprobes.h | 16 +- arch/x86/kernel/uprobes.c | 551 +++++++++++++++++++++++++--------------- kernel/events/uprobes.c | 31 +-- 3 files changed, 372 insertions(+), 226 deletions(-)