Skip to content

genirq/exynos timers: Fix the CPU hotplug wreckage sanely

Thomas Gleixner linux-arm-kernel lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4genirq: Allow forcing cpu affinity of interruptsarch/mips/cavium-octeon/octeon-irq.c include/linux/interrupt.h include/linux/irq.h +1 more+43 -140 replies
2/4irqchip: gic: Support forced affinity settingdrivers/irqchip/irq-gic.c+6 -20 replies
3/4clocksource: exynos_mct: Use irq_force_affinity() in cpu bringupdrivers/clocksource/exynos_mct.c+1 -70 replies
4/4clocksource: exynos_mct: Register clock event after request_irq()drivers/clocksource/exynos_mct.c+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [patch 0/4] genirq/exynos timers: Fix the CPU hotplug wreckage sanely

The current implementation of irq_set_affinity() refuses rightfully to route an interrupt to an offline cpu.

But there is a special case, where this is actually desired. Some of the ARM SoCs have per cpu timers which require setting the affinity during cpu startup where the cpu is not yet in the online mask.

If we can't do that, then the local timer interrupt for the about to become online cpu is routed to some random online cpu.

The developers of the affected machines tried to work around that issue, but that results in a massive mess in that timer code.

It's saner to provide a facility to force the affinity and make the affected machines use that.

The following series implements that logic w/o impact on any existing users.

The change to the genirq core code is not that bad:

 arch/mips/cavium-octeon/octeon-irq.c |    2 +-
 include/linux/interrupt.h            |   35 ++++++++++++++++++++++++++++++++++-
 include/linux/irq.h                  |    3 ++-
 kernel/irq/manage.c                  |   17 ++++++-----------
 4 files changed, 43 insertions(+), 14 deletions(-)

The resulting fixup for gic/exynos_mct is:

 clocksource/exynos_mct.c |   12 +++---------
 irqchip/irq-gic.c        |    8 ++++++--
 2 files changed, 9 insertions(+), 11 deletions(-)

Krzysztofs proposed workaround was slightly smaller than that, but I prefer having a clean solution for backporting to stable rather than a messy hack around which works.

@Krzysztof: Can you please retest the series? I've changed the core implementation versus the first attempt to make it less intrusive.

Thanks,

tglx