Skip to content

sparse warning fixes in arch/sparc/

Sam Ravnborg sparclinux 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest29 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/29sparc32: rename mm/srmmu.h to mm/mm_32.harch/sparc/mm/leon_mm.c arch/sparc/mm/mm_32.h arch/sparc/mm/srmmu.c +1 more+6 -60 replies
2/29sparc32: fix sparse warning in fault_32.carch/sparc/mm/fault_32.c arch/sparc/mm/mm_32.h+12 -30 replies
3/29sparc32: fix sparse warning in init_32.carch/sparc/include/asm/pgtable_32.h arch/sparc/mm/srmmu.c+1 -20 replies
4/29sparc32: fix sparse warnings in srmmu.carch/sparc/mm/init_32.c arch/sparc/mm/iommu.c arch/sparc/mm/mm_32.h +1 more+11 -70 replies
5/29sparc32: fix sparse "Should it be static?" in mm/arch/sparc/mm/leon_mm.c arch/sparc/mm/mm_32.h arch/sparc/mm/srmmu.c+8 -40 replies
6/29sparc32: fix sparse warning in traps_32.carch/sparc/include/asm/bug.h arch/sparc/kernel/traps_32.c+2 -20 replies
7/29sparc32: fix sparse warnings in sun4m_irq.c and sun4d_irq.carch/sparc/include/asm/timer_32.h arch/sparc/kernel/irq.h arch/sparc/kernel/leon_kernel.c +1 more+7 -40 replies
8/29sparc32: fix sparse warnings in sun4d_irq.carch/sparc/include/asm/irq_32.h arch/sparc/kernel/irq.h arch/sparc/kernel/sun4d_irq.c+13 -80 replies
9/29sparc32: fix sparse warnings in irq_32.carch/sparc/include/asm/floppy_32.h arch/sparc/include/asm/setup.h arch/sparc/kernel/irq.h +1 more+21 -100 replies
10/29sparc32: fix sparse warnings in process_32.harch/sparc/kernel/kernel.h arch/sparc/kernel/process_32.c+10 -00 replies
11/29sparc32: fix sparse warnings in signal_32.carch/sparc/kernel/kernel.h arch/sparc/kernel/signal_32.c+14 -50 replies
12/29sparc32: fix sparse warnings in ioport.carch/sparc/include/asm/pgalloc_32.h arch/sparc/kernel/ioport.c+5 -30 replies
13/29sparc32: fix sparse warnings in setup_32.carch/sparc/include/asm/setup.h arch/sparc/kernel/setup_32.c arch/sparc/mm/init_32.c+6 -30 replies
14/29sparc32: fix sparse warnings in windows.carch/sparc/kernel/kernel.h arch/sparc/kernel/windows.c+7 -00 replies
15/29sparc: fix sparse warnings in cpu.carch/sparc/include/asm/cpudata.h arch/sparc/include/asm/cpudata_64.h arch/sparc/kernel/cpu.c+11 -50 replies
16/29sparc32: fix sparse warning in devices.carch/sparc/include/asm/setup.h arch/sparc/kernel/devices.c arch/sparc/mm/init_32.c+4 -20 replies
17/29sparc32: fix sparse warnings in tadpole.carch/sparc/kernel/devices.c arch/sparc/kernel/kernel.h arch/sparc/kernel/tadpole.c+9 -20 replies
18/29sparc32: fix sparse warnings in leon_pci_grpci1.carch/sparc/kernel/leon_pci_grpci1.c+6 -60 replies
19/29sparc32: fix sparse warnings in leon_pci_grpci2.carch/sparc/kernel/leon_pci_grpci2.c+9 -90 replies
20/29sparc32: fix sparse warnings in auxio_32.carch/sparc/include/asm/auxio.h arch/sparc/include/asm/auxio_64.h arch/sparc/kernel/auxio_32.c +2 more+16 -80 replies
21/29sparc32: fix sparse warnings in smp_32.carch/sparc/kernel/smp_32.c+3 -30 replies
22/29sparc32: fix sparse warning in ptrace_32.carch/sparc/kernel/kernel.h arch/sparc/kernel/ptrace_32.c+5 -00 replies
23/29sparc32: fix sparse warnings in unaligned_32.carch/sparc/include/asm/setup.h arch/sparc/kernel/kernel.h arch/sparc/kernel/unaligned_32.c +1 more+12 -30 replies
24/29sparc: fix sparse warnings in of_device_common.carch/sparc/kernel/of_device_common.c+3 -10 replies
25/29sparc32: fix sparse warnings in leon_kernel.carch/sparc/kernel/leon_kernel.c+3 -30 replies
26/29sparc32: fix sparse warnings in leon_pmc.carch/sparc/kernel/leon_pmc.c+4 -40 replies
27/29sparc32: fix sparse warnings in sun4m_smp.carch/sparc/kernel/kernel.h arch/sparc/kernel/smp_32.c+5 -30 replies
28/29sparc32: fix sparse warnings in sun4d_smp.carch/sparc/kernel/kernel.h arch/sparc/kernel/smp_32.c+5 -30 replies
29/29sparc32: fix sparse warnings in leon_smp.carch/sparc/kernel/kernel.h arch/sparc/kernel/leon_smp.c+3 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/29] sparse warning fixes in arch/sparc/

The following patch-set address a lot of sparse warnings in the sparc32 specific parts of arch/sparc/.
A few sparc64 bits are touched too when code are shared.

Within arch/sparc/mm/ only two warnings remains.
These are related to the return value of of_ioremap() which is __iomem.

Within arch/sparc/kernel/ only three files now produces sparse warnings:

    sys_sparc_32.c
    time_32.c
    auxio_32.c

The fixes was not obvious so the warnings was left for now.

When looking at tadpole.c I was left with the impression that most of the code was actually unused - but for now I added a "TODO".

This is made on top of 3.15-rc2.

This set replaces the two sets sent the last days. V2:
- Do not add extern in front of prototypes.
- Tidy up a few changelongs

There are still sparse warnings left that are easy to address. But this fixes the majority.

Sam

Sam Ravnborg (29):
sparc32: rename mm/srmmu.h to mm/mm_32.h
sparc32: fix sparse warning in fault_32.c
sparc32: fix sparse warning in init_32.c
sparc32: fix sparse warnings in srmmu.c
sparc32: fix sparse "Should it be static?" in mm/
sparc32: fix sparse warning in traps_32.c
sparc32: fix sparse warnings in sun4m_irq.c and sun4d_irq.c
sparc32: fix sparse warnings in sun4d_irq.c
sparc32: fix sparse warnings in irq_32.c
sparc32: fix sparse warnings in process_32.h
sparc32: fix sparse warnings in signal_32.c
sparc32: fix sparse warnings in ioport.c
sparc32: fix sparse warnings in setup_32.c
sparc32: fix sparse warnings in windows.c
sparc: fix sparse warnings in cpu.c
sparc32: fix sparse warning in devices.c
sparc32: fix sparse warnings in tadpole.c
sparc32: fix sparse warnings in leon_pci_grpci1.c
sparc32: fix sparse warnings in leon_pci_grpci2.c
sparc32: fix sparse warnings in auxio_32.c
sparc32: fix sparse warnings in smp_32.c
sparc32: fix sparse warning in ptrace_32.c
sparc32: fix sparse warnings in unaligned_32.c
sparc: fix sparse warnings in of_device_common.c
sparc32: fix sparse warnings in leon_kernel.c
sparc32: fix sparse warnings in leon_pmc.c
sparc32: fix sparse warnings in sun4m_smp.c
sparc32: fix sparse warnings in sun4d_smp.c
sparc32: fix sparse warnings in leon_smp.c

 arch/sparc/include/asm/auxio.h       |  7 ++++++
 arch/sparc/include/asm/auxio_64.h    |  2 --
 arch/sparc/include/asm/bug.h         |  2 +-
 arch/sparc/include/asm/cpudata.h     | 10 ++++++++
 arch/sparc/include/asm/cpudata_64.h  |  5 ----
 arch/sparc/include/asm/floppy_32.h   | 11 ++-------
 arch/sparc/include/asm/irq_32.h      |  1 +
 arch/sparc/include/asm/pgalloc_32.h  |  2 ++
 arch/sparc/include/asm/pgtable_32.h  |  1 +
 arch/sparc/include/asm/setup.h       | 25 +++++++++++++++++++-
 arch/sparc/include/asm/timer_32.h    |  2 +-
 arch/sparc/kernel/auxio_32.c         |  3 +++
 arch/sparc/kernel/cpu.c              |  1 +
 arch/sparc/kernel/devices.c          | 11 ++++-----
 arch/sparc/kernel/ioport.c           |  6 ++---
 arch/sparc/kernel/irq.h              |  9 ++++++++
 arch/sparc/kernel/irq_32.c           |  1 +
 arch/sparc/kernel/kernel.h           | 44 ++++++++++++++++++++++++++++++++++++
 arch/sparc/kernel/leon_kernel.c      | 11 +++++----
 arch/sparc/kernel/leon_pci_grpci1.c  | 12 +++++-----
 arch/sparc/kernel/leon_pci_grpci2.c  | 18 +++++++--------
 arch/sparc/kernel/leon_pmc.c         |  8 +++----
 arch/sparc/kernel/leon_smp.c         | 13 +----------
 arch/sparc/kernel/of_device_common.c |  4 +++-
 arch/sparc/kernel/process_32.c       |  4 ++++
 arch/sparc/kernel/ptrace_32.c        |  2 ++
 arch/sparc/kernel/setup_32.c         |  4 ++--
 arch/sparc/kernel/signal_32.c        | 11 +++++----
 arch/sparc/kernel/smp_32.c           | 12 +++-------
 arch/sparc/kernel/sun4d_irq.c        | 17 +++++++-------
 arch/sparc/kernel/tadpole.c          |  6 ++++-
 arch/sparc/kernel/time_32.c          |  2 +-
 arch/sparc/kernel/traps_32.c         |  2 +-
 arch/sparc/kernel/unaligned_32.c     |  4 ++++
 arch/sparc/kernel/windows.c          |  3 +++
 arch/sparc/mm/fault_32.c             |  9 +++-----
 arch/sparc/mm/init_32.c              |  7 +++---
 arch/sparc/mm/iommu.c                |  5 ++--
 arch/sparc/mm/leon_mm.c              |  4 ++--
 arch/sparc/mm/mm_32.h                | 25 ++++++++++++++++++++
 arch/sparc/mm/srmmu.c                | 13 ++++-------
 arch/sparc/mm/srmmu.h                |  4 ----
 42 files changed, 222 insertions(+), 121 deletions(-)