Skip to content

uprobes/x86: completely untangle branch_xol_ops and default_xol_ops

Oleg Nesterov lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5uprobes/x86: Don't change the task's state if ->pre_xol() failsarch/x86/kernel/uprobes.c+6 -20 replies
2/5uprobes/x86: Introduce uprobe_xol_ops->abort() and default_abort_op()arch/x86/kernel/uprobes.c+11 -30 replies
3/5uprobes/x86: Don't use arch_uprobe_abort_xol() in arch_uprobe_post_xol()arch/x86/kernel/uprobes.c+9 -80 replies
4/5uprobes/x86: Move UPROBE_FIX_SETF logic from arch_uprobe_post_xol() to default_post_xol_op()arch/x86/kernel/uprobes.c+12 -80 replies
5/5uprobes/x86: Move default_xol_ops's data into arch_uprobe->defarch/x86/include/asm/uprobes.h arch/x86/kernel/uprobes.c+27 -262 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchJim Keniston
1/5
2/5
3/5
4/5
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] uprobes/x86: completely untangle branch_xol_ops and default_xol_ops
Quoted 3 lines · Oleg Nesterov

This series only fixes the problem. I'll send more changes to address some of TODO's mentioned in the changelogs later.

Another series which connects to the already merged changes.

All changes were planned, except 1/5 fixes the oversight in 8ad8e9d3fd64 "uprobes/x86: Introduce uprobe_xol_ops and arch_uprobe->ops". Fortunately the wrong logic is harmless currently, but it should be fixed anyway.

Oleg.

 arch/x86/include/asm/uprobes.h |   12 +++--
 arch/x86/kernel/uprobes.c      |   94 +++++++++++++++++++++++----------------
 2 files changed, 62 insertions(+), 44 deletions(-)